KEMBAR78
Fix `torch.finfo.bits` typo in stub by eternalphane · Pull Request #58819 · pytorch/pytorch · GitHub
Skip to content

Conversation

@eternalphane
Copy link
Contributor

Fixes #58818.

@facebook-github-bot
Copy link
Contributor

Hi @eternalphane!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 23, 2021

💊 CI failures summary and remediations

As of commit a07bcbc (more details on the Dr. CI page):


  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / test (1/1)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-05-24T16:55:43.2515504Z Build left local git repository checkout dirty
2021-05-24T16:55:43.2511337Z  M third_party/onnx-tensorrt
2021-05-24T16:55:43.2511705Z  M third_party/protobuf
2021-05-24T16:55:43.2512082Z  M third_party/pthreadpool
2021-05-24T16:55:43.2512443Z  M third_party/pybind11
2021-05-24T16:55:43.2512967Z  M third_party/python-peachpy
2021-05-24T16:55:43.2513444Z  M third_party/python-six
2021-05-24T16:55:43.2513805Z  M third_party/sleef
2021-05-24T16:55:43.2514124Z  M third_party/tbb
2021-05-24T16:55:43.2514444Z  M third_party/zstd ]]
2021-05-24T16:55:43.2514987Z + echo 'Build left local git repository checkout dirty'
2021-05-24T16:55:43.2515504Z Build left local git repository checkout dirty
2021-05-24T16:55:43.2516045Z + echo 'git status --porcelain:'
2021-05-24T16:55:43.2516505Z git status --porcelain:
2021-05-24T16:55:43.2516957Z + echo ' M third_party/fbgemm
2021-05-24T16:55:43.2517303Z  M third_party/kineto
2021-05-24T16:55:43.2517649Z  M third_party/neon2sse
2021-05-24T16:55:43.2517973Z  M third_party/onnx
2021-05-24T16:55:43.2518419Z  M third_party/onnx-tensorrt
2021-05-24T16:55:43.2518789Z  M third_party/protobuf
2021-05-24T16:55:43.2519166Z  M third_party/pthreadpool
2021-05-24T16:55:43.2519529Z  M third_party/pybind11

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #58819 (a07bcbc) into master (28840b9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #58819      +/-   ##
==========================================
- Coverage   76.55%   76.55%   -0.01%     
==========================================
  Files        2005     2005              
  Lines      200930   200930              
==========================================
- Hits       153828   153817      -11     
- Misses      47102    47113      +11     

@zou3519 zou3519 requested a review from rgommers May 24, 2021 14:54
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 24, 2021
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eternalphane, this looks good.

finfo/iinfo are so simple that I don't think a regression test is needed here. Seems good to land as is.

@rgommers rgommers requested a review from walterddr May 24, 2021 15:23
@facebook-github-bot
Copy link
Contributor

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 76f03bc.

@eternalphane eternalphane deleted the fix-58818 branch May 25, 2021 05:05
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
Summary:
Fixes pytorch#58818.

Pull Request resolved: pytorch#58819

Reviewed By: walterddr, malfet

Differential Revision: D28641587

Pulled By: ezyang

fbshipit-source-id: b19b519db43f2075c64f4f9ba922310f2561ca70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo for type of torch.finfo.bits in stub

8 participants