-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Fix torch.finfo.bits typo in stub
#58819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @eternalphane! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit a07bcbc (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #58819 +/- ##
==========================================
- Coverage 76.55% 76.55% -0.01%
==========================================
Files 2005 2005
Lines 200930 200930
==========================================
- Hits 153828 153817 -11
- Misses 47102 47113 +11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eternalphane, this looks good.
finfo/iinfo are so simple that I don't think a regression test is needed here. Seems good to land as is.
|
@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Fixes pytorch#58818. Pull Request resolved: pytorch#58819 Reviewed By: walterddr, malfet Differential Revision: D28641587 Pulled By: ezyang fbshipit-source-id: b19b519db43f2075c64f4f9ba922310f2561ca70
Fixes #58818.