KEMBAR78
Remove many unnecessary constructor calls of Vectorized<T> by xuhdev · Pull Request #58875 · pytorch/pytorch · GitHub
Skip to content

Remove many unnecessary constructor calls of Vectorized<T> #58875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove many unnecessary constructor calls of Vectorized<T> #58875

wants to merge 1 commit into from

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented May 24, 2021

Refresh #56241

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 24, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3f6b305 (more details on the Dr. CI page):

  • 9/9 failures possibly* introduced in this PR
    • 1/9 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Windows CI (pytorch-win-vs2019-cpu-py3) / test (1/1)

Step: "Run test scripts" (full log | diagnosis details | 🔁 rerun)

2021-06-04T01:30:53.1227052Z Build left local git repository checkout dirty 
2021-06-04T01:30:52.9635937Z ++ git status --porcelain
2021-06-04T01:30:53.1223902Z + git_status=' M third_party/fbgemm
2021-06-04T01:30:53.1224348Z  M third_party/onnx'
2021-06-04T01:30:53.1224656Z + [[ -n  M third_party/fbgemm
2021-06-04T01:30:53.1224968Z  M third_party/onnx ]]
2021-06-04T01:30:53.1225363Z + echo 'Build left local git repository checkout dirty'
2021-06-04T01:30:53.1225778Z + echo 'git status --porcelain:'
2021-06-04T01:30:53.1226123Z + echo ' M third_party/fbgemm
2021-06-04T01:30:53.1226424Z  M third_party/onnx'
2021-06-04T01:30:53.1226688Z + exit 1
2021-06-04T01:30:53.1227052Z Build left local git repository checkout dirty
2021-06-04T01:30:53.1227439Z git status --porcelain:
2021-06-04T01:30:53.1227742Z  M third_party/fbgemm
2021-06-04T01:30:53.1228034Z  M third_party/onnx
2021-06-04T01:30:53.1228297Z + cleanup
2021-06-04T01:30:53.1228554Z + retcode=1
2021-06-04T01:30:53.1228786Z + set +x
2021-06-04T01:30:53.1257150Z ##[error]Process completed with exit code 1.
2021-06-04T01:30:53.1586069Z ##[group]Run actions/upload-artifact@v2
2021-06-04T01:30:53.1586471Z with:
2021-06-04T01:30:53.1586755Z   name: test-reports

7 failures not recognized by patterns:

Job Step Action
GitHub Actions Lint / shellcheck Checkout PyTorch 🔁 rerun
GitHub Actions Lint / py2-setup-validate-errormsg Checkout PyTorch 🔁 rerun
GitHub Actions Lint / toc Checkout PyTorch 🔁 rerun
GitHub Actions Lint / quick-checks Checkout PyTorch 🔁 rerun
GitHub Actions Linux CI (pytorch-linux-xenial-py3.6-gcc5.4) / calculate-docker-image Set up job 🔁 rerun
GitHub Actions Lint / cmakelint Fetch PyTorch 🔁 rerun
CircleCI pytorch_linux_bionic_py3_8_gcc9_coverage_test2 Run tests 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@xuhdev xuhdev mentioned this pull request May 24, 2021
Closed
@gchanan gchanan requested a review from VitalyFedyunin May 25, 2021 21:23
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 25, 2021
@xuhdev xuhdev requested a review from ezyang June 3, 2021 21:17
ezyang
ezyang approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey dokey

@facebook-github-bot
Copy link
Contributor

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in 202b2c9.

@xuhdev xuhdev deleted the vec/construct branch June 6, 2021 06:18
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@xuhdev @deniskokarev
Remove many unnecessary constructor calls of Vectorized<T> (pytorch#5…
cbe46b1 
…8875)

Summary:
Refresh pytorch#56241

Pull Request resolved: pytorch#58875

Reviewed By: mruberry

Differential Revision: D28892034

Pulled By: ezyang

fbshipit-source-id: 21074e45f29a780168852be5305420a3cc1148fc
@imaginary-person imaginary-person mentioned this pull request Jul 7, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xuhdev @facebook-github-bot @ezyang @gchanan @pytorchbot