KEMBAR78
Move remaining \*Sort\* in `THC` to `ATen` by eqy · Pull Request #58953 · pytorch/pytorch · GitHub
Skip to content

Move remaining \*Sort\* in THC to ATen #58953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Move remaining \*Sort\* in THC to ATen #58953

wants to merge 4 commits into from

Conversation

@eqy
Copy link
Collaborator

@eqy eqy commented May 25, 2021

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit ae6475e (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@eqy
Copy link
Collaborator Author

eqy commented May 25, 2021 •
edited
Loading

I'm unsure of what the gymnastics of using a __device__ function in at::native from THC look like so getLinearBlockId() is still defined in multiple places.

@anjali411 anjali411 requested a review from ngimel May 26, 2021 15:38
@anjali411 anjali411 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 26, 2021
ngimel
ngimel reviewed May 27, 2021
View reviewed changes
Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, otherwise looks good, great cleanup!

aten/src/ATen/native/cuda/Sort.cu Outdated
if (dir) { \
bitonicSortKVInPlace<scalar_t, int64_t, A, -1, \
GTComp<scalar_t, true>, TYPE, SIZE> \
ThrustGTOp<scalar_t, true>, TYPE, SIZE> \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably makes sense to rename it to GTComp? There's no thrust around anymore

@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 4e543d0.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@eqy @deniskokarev
Move remaining \*Sort\* in THC to ATen (pytorch#58953)
b6a3ee9 
Summary:
pytorch#24637

CC zasdfgbnm ngimel

Pull Request resolved: pytorch#58953

Reviewed By: mrshenli

Differential Revision: D28749713

Pulled By: ngimel

fbshipit-source-id: 33ce87cf77e23d5d67d193d6368131cb8dab39ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eqy @facebook-github-bot @ngimel @anjali411 @pytorchbot