KEMBAR78
DOC Adds register_module_full_backward_hook into docs by thomasjpfan · Pull Request #58954 · pytorch/pytorch · GitHub
Skip to content

DOC Adds register_module_full_backward_hook into docs #58954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

DOC Adds register_module_full_backward_hook into docs #58954

wants to merge 3 commits into from

Conversation

@thomasjpfan
Copy link
Contributor

Fixes #54443

Adds register_module_full_backward_hook into the index so it is rendered in the html docs.

@thomasjpfan thomasjpfan added module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 25, 2021
@thomasjpfan thomasjpfan requested a review from jbschlosser May 25, 2021 22:01
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 25, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 688e4d7 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_xla_linux_bionic_py3_6_clang9_test Run tests 🔁 rerun

XLA failure

Job pytorch_xla_linux_bionic_py3_6_clang9_test is failing. Please create an issue with title prefixed by [PT_BREAK] in pytorch/xla and link to to this PR. If you have questions, please reach out to @ailzhang / @dlibenzi / @JackCaoG.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

jbschlosser
jbschlosser reviewed Jun 1, 2021
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Would you mind also tweaking the link to the function from register_backward_hook() so it renders correctly?

pytorch/torch/nn/modules/module.py

Line 859 in afdfd22

This function is deprecated in favor of :meth:`nn.Module.register_full_backward_hook` and

I think the above link should be this instead:

`:meth:`~torch.nn.Module.register_full_backward_hook`

@thomasjpfan thomasjpfan requested a review from albanD as a code owner June 1, 2021 16:11
jbschlosser
jbschlosser approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks for the update :)

@facebook-github-bot
Copy link
Contributor

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jbschlosser merged this pull request in 8af6281.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@thomasjpfan @deniskokarev
DOC Adds register_module_full_backward_hook into docs (pytorch#58954)
512195c 
Summary:
Fixes pytorch#54443

Adds `register_module_full_backward_hook` into the index so it is rendered in the html docs.

Pull Request resolved: pytorch#58954

Reviewed By: ngimel

Differential Revision: D28801816

Pulled By: jbschlosser

fbshipit-source-id: a2e737fe983e5d7e4e26d7639183bca34b571cb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

cla signed Merged module: nn Related to torch.nn open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for register_module_full_backward_hook

4 participants

@thomasjpfan @facebook-github-bot @jbschlosser @pytorchbot