KEMBAR78
Back out "[pytorch][PR] ENH Adds dtype to nn.functional.one_hot" by jbschlosser · Pull Request #59080 · pytorch/pytorch · GitHub
Skip to content

Conversation

@jbschlosser
Copy link
Contributor

@jbschlosser jbschlosser commented May 27, 2021

Summary: Original commit changeset: 3686579517cc

Test Plan: None; reverting diff

Differential Revision: D28746799

Original PR: #58090

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 27, 2021

💊 CI failures summary and remediations

As of commit 276db00 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28746799

@jbschlosser
Copy link
Contributor Author

Reverting #58090 as it apparently breaks internal production models. Investigating the problem + gaps in test coverage now.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…orch#59080)

Summary:
Pull Request resolved: pytorch#59080

Original commit changeset: 3686579517cc

Test Plan: None; reverting diff

Reviewed By: albanD

Differential Revision: D28746799

fbshipit-source-id: 09e233ca7b33f1dd7f110e685ffba9b1126c1c75
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D28746799

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ef32a29.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
…orch#59080)

Summary:
Pull Request resolved: pytorch#59080

Original commit changeset: 3686579517cc

Test Plan: None; reverting diff

Reviewed By: albanD

Differential Revision: D28746799

fbshipit-source-id: 75a7885ab0bf3abadde9a42b56d479f71f57c89c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants