KEMBAR78
Fixed torch.nn.MultiMarginLoss equation format error by aflah02 · Pull Request #59188 · pytorch/pytorch · GitHub
Skip to content

Fixed torch.nn.MultiMarginLoss equation format error #59188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed torch.nn.MultiMarginLoss equation format error #59188

wants to merge 2 commits into from

Conversation

@aflah02
Copy link
Contributor

@aflah02 aflah02 commented May 30, 2021 •
edited by jbschlosser
Loading

Removed the extra parenthesis from the right side
Fixes #58634

aflah02 added 2 commits May 30, 2021 23:25
@aflah02
Update loss.py
16f6780 
Fixed extra ')' in the formula for MULTIMARGINLOSS given in the documentation
@aflah02
Merge pull request #1 from aflah02/aflah02-patch-1
e363367 
Update loss.py
@facebook-github-bot
Copy link
Contributor

Hi @aflah02!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 30, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit e363367 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@aflah02
Copy link
Contributor Author

aflah02 commented Jun 1, 2021

Hey @albanD @jbschlosser I'm not sure why one of the build fails. What's going wrong?

@jbschlosser
Copy link
Contributor

Hey @albanD @jbschlosser I'm not sure why one of the build fails. What's going wrong?

@aflah02 Looks unrelated to your change. Sometimes there are pre-existing failures.

jbschlosser
jbschlosser approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@facebook-github-bot
Copy link
Contributor

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@aflah02
Copy link
Contributor Author

aflah02 commented Jun 1, 2021

lgtm! thanks

You're welcome!

@facebook-github-bot
Copy link
Contributor

@jbschlosser merged this pull request in fd2a363.

deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@aflah02 @deniskokarev
Fixed torch.nn.MultiMarginLoss equation format error (pytorch#59188)
9a97ed7 
Summary:
Removed the extra parenthesis from the right side
Fixes pytorch#58634

Pull Request resolved: pytorch#59188

Reviewed By: ngimel

Differential Revision: D28797720

Pulled By: jbschlosser

fbshipit-source-id: 47e3084526389e7d1cc17c1a01b253e666c58784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.nn.MultiMarginLoss：equation format error

4 participants

@aflah02 @facebook-github-bot @jbschlosser @pytorchbot