KEMBAR78
Fix mismatch in README.md Docker Image section by ChenYuHo · Pull Request #59199 · pytorch/pytorch · GitHub
Skip to content

Fix mismatch in README.md Docker Image section #59199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix mismatch in README.md Docker Image section #59199

wants to merge 1 commit into from

Conversation

@ChenYuHo
Copy link
Contributor

docker.Makefile has CUDNN_VERSION=8 as the defaults, but README.md states cuDNN v7

@ChenYuHo
Fix mismatch in README.md Docker Image section
abc4774 
docker.Makefile has CUDNN_VERSION=8 as the defaults, but README.md states cuDNN v7
@facebook-github-bot
Copy link
Contributor

Hi @ChenYuHo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 31, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit abc4774 (more details on the Dr. CI page):

  • 25/25 failures introduced in this PR

25 failures not recognized by patterns:

Job Step Action
CircleCI binary_linux_libtorch_3_7m_cpu_gcc5_4_cxx11-abi_shared-with-deps_build Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-py3.6-gcc5.4 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-py3.8 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-cuda10.2-cudnn7-py3.6-clang9 Unknown 🔁 rerun
CircleCI pytorch_windows_vs2019_py36_cuda11.1_build Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-rocm3.9-py3.6 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-cuda10.2-cudnn7-py3.9-gcc7 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-cuda10.1-cudnn7-py3-gcc7 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-py3.8-gcc9 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-py3-clang7-onnx Unknown 🔁 rerun
CircleCI pytorch_ios_12_0_0_x86_64_full_jit_build Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-cuda10.2-cudnn7-py3-gcc7 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-py3.6-gcc7 Unknown 🔁 rerun
CircleCI pytorch_macos_10_15_py3_build Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-rocm4.1-py3.6 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-rocm4.0.1-py3.6 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-cuda11.1-cudnn8-py3-gcc7 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-py3.6-clang9 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-bionic-rocm4.2-py3.6 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-py3-clang5-asan Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-py3.6-clang7 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-cuda10-cudnn7-py3-gcc7 Unknown 🔁 rerun
CircleCI docker-pytorch-linux-xenial-py3-clang5-android-ndk-r19c Unknown 🔁 rerun
CircleCI pytorch_ios_12_0_0_x86_64_build Unknown 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 336ac94.

@ChenYuHo ChenYuHo deleted the patch-1 branch June 2, 2021 15:08
deniskokarev pushed a commit to deniskokarev/pytorch that referenced this pull request Jun 9, 2021
@ChenYuHo @deniskokarev
Fix mismatch in README.md Docker Image section (pytorch#59199)
092a103 
Summary:
docker.Makefile has CUDNN_VERSION=8 as the defaults, but README.md states cuDNN v7

Pull Request resolved: pytorch#59199

Reviewed By: mruberry

Differential Revision: D28808611

Pulled By: ngimel

fbshipit-source-id: 96cea32bfe33184b2bff69b7bb7f3e50a2b9c6aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ChenYuHo @facebook-github-bot @ngimel @pytorchbot