[reland] Create CUDA-aware futures in RequestCallback #59209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reland of #58426 The operations in RequestCallback can return CUDA tensors, thus the futures used to hold them must be CUDA-aware. Differential Revision: [D28623887](https://our.internmc.facebook.com/intern/diff/D28623887/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit 5f6aed6 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced May 31, 2021
mrshenli
approved these changes
Jun 1, 2021
|
This pull request has been merged in f8a3fd4. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#59209 Reland of pytorch#58426 The operations in RequestCallback can return CUDA tensors, thus the futures used to hold them must be CUDA-aware. ghstack-source-id: 130202844 Test Plan: CI Reviewed By: mrshenli Differential Revision: D28623887 fbshipit-source-id: 53561b8ae011458d8f848f0a03830925aff2f0c2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Reland of #58426
The operations in RequestCallback can return CUDA tensors, thus the futures used to hold them must be CUDA-aware.
Differential Revision: D28623887