Remove LazyStreamContext (2 out of 2) #59299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
lw
requested review from
H-Huang,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit 8a1dfce (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 2, 2021
lw
added a commit
that referenced
this pull request
Jun 2, 2021
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) ghstack-source-id: 130359961 Pull Request resolved: #59299
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 3, 2021
Pull Request resolved: #59299 After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. ghstack-source-id: 130473860 Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/)
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 3, 2021
Pull Request resolved: #59299 After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. ghstack-source-id: 130478940 Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/)
mrshenli
reviewed
Jun 3, 2021
| const std::vector<torch::Tensor>& tensors) { | ||
| c10::optional<c10::impl::VirtualGuardImpl> impl; | ||
| size_t deviceCount = 0; | ||
| std::vector<bool> indexBitSet; |
There was a problem hiding this comment.
curious about this var name. It seems to be neither bit nor set? Or is it possible to use a real std::bitset here?
There was a problem hiding this comment.
This is probably not the best capitalization, but the name was meant to be "a bitset of indices". It is conceptually identical to std::bitset, but if you notice std::bitset requires a compile-time size. The doc for std::bitset says:
If the size of the bitset is not known at compile time,
std::vector<bool>may be used.
Hope this clarifies. I'll fix the capitalization.
| } | ||
| std::vector<c10::Device> devices; | ||
| devices.reserve(deviceCount); | ||
| for (c10::DeviceIndex idx = 0; idx < indexBitSet.size(); idx++) { |
There was a problem hiding this comment.
The linter is correct "in principle" but here we know that the size of the vector will fit in a DeviceIndex because we used a DeviceIndex to resize the vector.
I'm starting to think that perhaps we should create a dedicated DeviceVector class, that can provide properly-typed accessors, can perhaps use small-vector optimizations, ...
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
This was referenced Jun 3, 2021
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
mrshenli
approved these changes
Jun 4, 2021
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. Differential Revision: [D28789174](https://our.internmc.facebook.com/intern/diff/D28789174/) [ghstack-poisoned]
|
This pull request has been merged in c09beaa. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Pull Request resolved: pytorch#59299 After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type. This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals. ghstack-source-id: 130583773 Test Plan: CI Reviewed By: mrshenli Differential Revision: D28789174 fbshipit-source-id: a27d2b1f40ab3cf2ac0dd946232fd0eecda6d450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
After recent changes, LazyStreamContext had in fact always become eager, and was in fact equivalent to a vector of streams. So it makes more sense now to remove this abstraction and use a more self-descriptive type.
This PR migrates the TensorPipe agent. The previous PR migrated the RequestCallback internals.
Differential Revision: D28789174