[DDP] Rename the member divFactor_ as div_factor for naming consistency in reducer #59523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cy in reducer Should use snake case instead of camel case for the consistency. Differential Revision: [D28922896](https://our.internmc.facebook.com/intern/diff/D28922896/) [ghstack-poisoned]
wayi1
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit db117fe (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
This was referenced Jun 6, 2021
wayi1
pushed a commit
that referenced
this pull request
Jun 6, 2021
…cy in reducer Should use snake case instead of camel case for the consistency. Differential Revision: [D28922896](https://our.internmc.facebook.com/intern/diff/D28922896/) ghstack-source-id: 130686880 Pull Request resolved: #59523
…g consistency in reducer" Should use snake case instead of camel case for the consistency. Differential Revision: [D28922896](https://our.internmc.facebook.com/intern/diff/D28922896/) [ghstack-poisoned]
This was referenced Jun 7, 2021
wayi1
pushed a commit
that referenced
this pull request
Jun 7, 2021
…cy in reducer Pull Request resolved: #59523 Should use snake case instead of camel case for the consistency. ghstack-source-id: 130759655 Differential Revision: [D28922896](https://our.internmc.facebook.com/intern/diff/D28922896/)
|
This pull request has been merged in 31d136c. |
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
…cy in reducer (pytorch#59523) Summary: Pull Request resolved: pytorch#59523 Should use snake case instead of camel case for the consistency. ghstack-source-id: 130759655 Test Plan: buck test mode/dev-nosan caffe2/test/distributed:distributed_nccl_fork -- test_ddp_grad_div_uneven_inputs Reviewed By: cbalioglu Differential Revision: D28922896 fbshipit-source-id: e04298284a78b2e71b562f790a878731962f873a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Should use snake case instead of camel case for the consistency.
Differential Revision: D28922896