Move c10d to libtorch(_cuda) #59563
Closed
Move c10d to libtorch(_cuda) #59563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 160683d (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
This was referenced Jun 7, 2021
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
This was referenced Jun 9, 2021
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 9, 2021
Pull Request resolved: #59563 ghstack-source-id: 130932256 Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)!
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 10, 2021
Pull Request resolved: #59563 ghstack-source-id: 131056993 Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)!
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 10, 2021
Pull Request resolved: #59563 ghstack-source-id: 131064301 Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)!
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 11, 2021
Pull Request resolved: #59563 ghstack-source-id: 131169543 Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)!
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 11, 2021
Pull Request resolved: #59563 ghstack-source-id: 131181183 Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)!
malfet
approved these changes
Jun 14, 2021
tools/build_variables.bzl
Outdated
| libtorch_core_sources = sorted(core_sources_common + core_sources_full + core_trainer_sources) | ||
|
|
||
| libtorch_distributed_sources = [ | ||
| libtorch_distributed_windows_sources = [ |
There was a problem hiding this comment.
Nit: Please consider renaming libtorch_distributed_windows_sources to libtorch_distribtued_base_sources, as there are nothing windows specific about them
Suggested change
| libtorch_distributed_windows_sources = [ | |
| libtorch_distributed_base_sources = [ |
There was a problem hiding this comment.
I called them windows because they're the only sources that are safe to build under Windows. I'll rename them to base as suggested, and add a comment to clarify why we need to separate them.
tools/build_variables.bzl
Outdated
| "torch/lib/c10d/Utils.cpp", | ||
| ] | ||
|
|
||
| libtorch_distributed_sources = libtorch_distributed_windows_sources + [ |
There was a problem hiding this comment.
If filelists are split into base and c10d source if we replace if();add();else();add();endif() into add(base);if();add(extra);endif();
Suggested change
| libtorch_distributed_sources = libtorch_distributed_windows_sources + [ | |
| libtorch_distributed_c10d_sources = [ |
There was a problem hiding this comment.
I don't want to use c10d in the name because after this change we'll be able to also move the RPC layer from libtorch_python to libtorch and its files would be added to this list as well. But I'm fine with calling it extra as suggested.
There was a problem hiding this comment.
How about libtorch_distributed_extra_sources
There was a problem hiding this comment.
Yes that's what I went with. I also left libtorch_distributed_sources defined as the union of base+extra, since it's handy internally. Hope this is fine?
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 14, 2021
Pull Request resolved: #59563 ghstack-source-id: 131329887 Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)!
Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)! [ghstack-poisoned]
lw
added a commit
that referenced
this pull request
Jun 14, 2021
Pull Request resolved: #59563 ghstack-source-id: 131331264 Differential Revision: [D28932239](https://our.internmc.facebook.com/intern/diff/D28932239/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D28932239/)!
|
This pull request has been merged in a178043. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D28932239
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!