[c10d] Use TORCH_CHECK for monitored barrier error #59667
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use torch_check over throw std::runtime_error in monitored barrier so that it works with torch_cpp_show_stacktraces to reveal the entire callstack where the monitored barrier failed, which can help determine where the particular rank encountered an issue. Differential Revision: [D28974510](https://our.internmc.facebook.com/intern/diff/D28974510/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 7462f94 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Jun 8, 2021
Use torch_check over throw std::runtime_error in monitored barrier so that it works with torch_cpp_show_stacktraces to reveal the entire callstack where the monitored barrier failed, which can help determine where the particular rank encountered an issue. Differential Revision: [D28974510](https://our.internmc.facebook.com/intern/diff/D28974510/) ghstack-source-id: 130879792 Pull Request resolved: #59667
This was referenced Jun 9, 2021
Use torch_check over throw std::runtime_error in monitored barrier so that it works with torch_cpp_show_stacktraces to reveal the entire callstack where the monitored barrier failed, which can help determine where the particular rank encountered an issue. We should eventually replace all uses of throwing runtime_error with torch_check in distributed C++ code as the latter can provide cpp stack traces. Differential Revision: [D28974510](https://our.internmc.facebook.com/intern/diff/D28974510/) [ghstack-poisoned]
|
This pull request has been merged in fc0582e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Use torch_check over throw std::runtime_error in monitored barrier so
that it works with torch_cpp_show_stacktraces to reveal the entire callstack
where the monitored barrier failed, which can help determine where the
particular rank encountered an issue.
We should eventually replace all uses of throwing runtime_error with torch_check in distributed C++ code as the latter can provide cpp stack traces.
Differential Revision: D28974510