Fix bad change in a CUDACachingAllocator loop #59903
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 25b66c6 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
This pull request was exported from Phabricator. Differential Revision: D29081688 |
r-barnes
force-pushed
the
export-D29081688
branch
from
3a56a9e to
623c07f
Compare
Summary: Pull Request resolved: pytorch#59903 D29034650 (pytorch@cf0c4ac) probably breaks something because it changes a `for` loop on ~Line 1200 from `[size,max)` to `[0,max)`. This fixes that Test Plan: Sandcastle Differential Revision: D29081688 fbshipit-source-id: 7057e3eb3737daa9d296f6a87ce2bd7de8fe997c
|
This pull request was exported from Phabricator. Differential Revision: D29081688 |
r-barnes
force-pushed
the
export-D29081688
branch
from
623c07f to
25b66c6
Compare
|
This pull request has been merged in 10a3a3d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: D29034650 (cf0c4ac) probably breaks something because it changes a for loop from
[size,max)to[0,max). This fixes thatTest Plan: Sandcastle
Differential Revision: D29081688