[reland] torch/lib/c10d: Use torch_check instead of throwing runtime_error #59918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error Reland of #59684 Differential Revision: [D29081452](https://our.internmc.facebook.com/intern/diff/D29081452/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit c65bde5 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Jun 13, 2021
…error Reland of #59684 Differential Revision: [D29081452](https://our.internmc.facebook.com/intern/diff/D29081452/) ghstack-source-id: 131303057 Pull Request resolved: #59918
|
This pull request has been merged in 580a20f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Reland of #59684
Fix is to update
ProcessGroupNCCLErrorsTestappropriately. CI all is in #59919Differential Revision: D29081452