KEMBAR78
Fix compile failure on CUDA92 by ejguan · Pull Request #60017 · pytorch/pytorch · GitHub
Skip to content

Fix compile failure on CUDA92 #60017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix compile failure on CUDA92 #60017

wants to merge 3 commits into from

Conversation

@ejguan
Copy link
Contributor

@ejguan ejguan commented Jun 15, 2021 •
edited
Loading

Fixes #60016

For CUDA 92

  • OptionalBase was not check if is_arrayref
  • constexpr seems not expect to raise Exception for cuda 92

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 15, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit f9fcd19 (more details on the Dr. CI page):

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_cpp_doc_build (1/1)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun) ❄️

Jun 16 14:06:35 E: Failed to fetch http://archi...to archive.ubuntu.com:http: [IP: 91.189.88.152 80] 
Jun 16 14:06:35 Err:24 http://security.ubuntu.com/ubuntu xenial-security/main amd64 libgc1c2 amd64 1:7.4.2-7.3ubuntu0.1
Jun 16 14:06:35   Unable to connect to archive.ubuntu.com:http: [IP: 91.189.88.152 80]
Jun 16 14:06:35 Err:25 http://archive.ubuntu.com/ubuntu xenial-updates/universe amd64 libclang1-3.8 amd64 1:3.8-2ubuntu4
Jun 16 14:06:35   Unable to connect to archive.ubuntu.com:http: [IP: 91.189.88.152 80]
Jun 16 14:06:35 Ign:26 http://security.ubuntu.com/ubuntu xenial-security/main amd64 doxygen amd64 1.8.11-1ubuntu0.1
Jun 16 14:06:35 Get:24 http://security.ubuntu.com/ubuntu xenial-security/main amd64 libgc1c2 amd64 1:7.4.2-7.3ubuntu0.1 [82.1 kB]
Jun 16 14:06:35 Get:26 http://security.ubuntu.com/ubuntu xenial-security/main amd64 doxygen amd64 1.8.11-1ubuntu0.1 [3679 kB]
Jun 16 14:06:35 Fetched 34.5 MB in 4min 0s (143 kB/s)
Jun 16 14:06:35 E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/l/llvm-toolchain-3.8/libllvm3.8_3.8-2ubuntu4_amd64.deb  Could not connect to archive.ubuntu.com:80 (91.189.88.152), connection timed out [IP: 91.189.88.152 80]
Jun 16 14:06:35 
Jun 16 14:06:35 E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/universe/l/llvm-toolchain-3.8/libclang1-3.8_3.8-2ubuntu4_amd64.deb  Unable to connect to archive.ubuntu.com:http: [IP: 91.189.88.152 80]
Jun 16 14:06:35 
Jun 16 14:06:35 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?


Exited with code exit status 100
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ejguan ejguan requested a review from walterddr June 15, 2021 15:02
@ejguan ejguan mentioned this pull request Jun 15, 2021
Closed
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

malfet
malfet requested changes Jun 15, 2021
View reviewed changes
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ejguan ejguan requested a review from malfet June 15, 2021 22:50
@malfet
Copy link
Contributor

malfet commented Jun 15, 2021

@ejguan please rebase your PR against master to enable CircleCI tests

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ejguan merged this pull request in 691183b.

@ejguan ejguan mentioned this pull request Jun 18, 2021
Closed
ejguan added a commit that referenced this pull request Jun 18, 2021
@ejguan
Update on "Follow-up fix for compilation error on CUDA92"
99c78bd 
Follow up of #60017

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jun 21, 2021
@ejguan @facebook-github-bot
Follow-up fix for compilation error on CUDA92 (#60287)
65f33ec 
Summary:
Pull Request resolved: #60287

Follow up of #60017

Test Plan: Imported from OSS

Reviewed By: gchanan

Differential Revision: D29236208

Pulled By: ejguan

fbshipit-source-id: f1acf9630b45fea8cbdf7d64e47661643d0a52b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@walterddr walterddr Awaiting requested review from walterddr

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compilation issue with CUDA 92

3 participants

@ejguan @facebook-github-bot @malfet