KEMBAR78
Set TORCH_WARN_ONCE to always warn inside of assertNotWarn by peterbell10 · Pull Request #60020 · pytorch/pytorch · GitHub
Skip to content

Set TORCH_WARN_ONCE to always warn inside of assertNotWarn #60020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Set TORCH_WARN_ONCE to always warn inside of assertNotWarn #60020

wants to merge 1 commit into from

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Jun 15, 2021 •
edited by mruberry
Loading

Stack from ghstack:

Differential Revision: D29249909

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 15, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit c5abaf3 (more details on the Dr. CI page and at hud.pytorch.org/pr/60020):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@peterbell10 peterbell10 mentioned this pull request Jun 15, 2021
Closed
@peterbell10 peterbell10 requested a review from mruberry June 15, 2021 16:04
@peterbell10 peterbell10 added the module: testing Issues related to the torch.testing module (not tests) label Jun 15, 2021
@peterbell10 peterbell10 mentioned this pull request Jun 15, 2021
Closed
mruberry
mruberry reviewed Jun 16, 2021
View reviewed changes
torch/testing/_internal/common_utils.py
return super().__exit__(exc_type, exc_value, tb)


@contextmanager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat

mruberry
mruberry approved these changes Jun 16, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peterbell10!

@mruberry
Copy link
Collaborator

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mruberry merged this pull request in 45ae2e7.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/73/head branch June 25, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: testing Issues related to the torch.testing module (not tests) open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterbell10 @facebook-github-bot @mruberry @pytorchbot