KEMBAR78
make it easier to grep for unary/binary op kernels by bdhirsh · Pull Request #60128 · pytorch/pytorch · GitHub
Skip to content

make it easier to grep for unary/binary op kernels #60128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

make it easier to grep for unary/binary op kernels #60128

wants to merge 1 commit into from

Conversation

@bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented Jun 16, 2021 •
edited
Loading

The existing macros for unary/binary ops prevent you from grepping for the round_out kernel

Stack from ghstack:

Differential Revision: D29175499

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 16, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 77db8b0 (more details on the Dr. CI page):

  • 2/3 failures introduced in this PR
  • 1/3 broken upstream at merge base d88fbf0 on Jun 16 from 9:30am to 10:21am

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 16 21:22:23 AssertionError: False is not tr...lowed difference with rtol=0 and atol=0 is only 0! 
Jun 16 21:22:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 516, in run_test
Jun 16 21:22:23     getattr(self, test_name)()
Jun 16 21:22:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_distributed.py", line 400, in wrapper
Jun 16 21:22:23     fn()
Jun 16 21:22:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/distributed/distributed_test.py", line 4591, in test_ddp_logging_data_cpu
Jun 16 21:22:23     self.assertEqual(ddp_logging_data.get("find_unused_parameters"), 0)
Jun 16 21:22:23   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 1419, in assertEqual
Jun 16 21:22:23     super().assertTrue(result, msg=self._get_assert_msg(msg, debug_msg=debug_msg))
Jun 16 21:22:23   File "/opt/conda/lib/python3.6/unittest/case.py", line 682, in assertTrue
Jun 16 21:22:23     raise self.failureException(msg)
Jun 16 21:22:23 AssertionError: False is not true : Scalars failed to compare as equal! Comparing 1 and 0 gives a difference of 1, but the allowed difference with rtol=0 and atol=0 is only 0!
Jun 16 21:22:23 
Jun 16 21:22:23 
Jun 16 21:22:23 
Jun 16 21:22:23 ----------------------------------------------------------------------
Jun 16 21:22:23 Ran 220 tests in 58.531s
Jun 16 21:22:23 
Jun 16 21:22:23 FAILED (errors=1, skipped=110)
Jun 16 21:22:23 
Jun 16 21:22:23 Generating XML reports...
Jun 16 21:22:23 Generated XML report: test-reports/dist-gloo/distributed.test_distributed_fork/TEST-TestDistBackendWithFork-20210616212124.xml

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Windows CI (pytorch-win-vs2019-cpu-py3) / render_test_results Download PyTorch Test Reports 🔁 rerun

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

bdhirsh added a commit that referenced this pull request Jun 16, 2021
@bdhirsh
make it easier to grep for unary/binary op kernels
8d594bf 
ghstack-source-id: 6340f59
Pull Request resolved: #60128
@bdhirsh
Copy link
Contributor Author

bdhirsh commented Jun 16, 2021

@bdhirsh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@bdhirsh bdhirsh requested a review from ezyang June 16, 2021 20:40
wenleix
wenleix approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@wenleix wenleix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this, yay

@facebook-github-bot
Copy link
Contributor

@bdhirsh merged this pull request in c458bb9.

@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/125/head branch June 20, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang Awaiting requested review from ezyang

1 more reviewer

@wenleix wenleix wenleix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdhirsh @facebook-github-bot @wenleix