Ensure num_threads is initialized before calling omp_get_max_threads #60185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. [ghstack-poisoned]
This was referenced Jun 17, 2021
💊 CI failures summary and remediationsAs of commit 38d45ca (more details on the Dr. CI page and at hud.pytorch.org/pr/60185):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
peterbell10
added
module: openmp
…ax_threads" `get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. [ghstack-poisoned]
…ax_threads" `get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. [ghstack-poisoned]
…ax_threads" `get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. [ghstack-poisoned]
…ax_threads" `get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. [ghstack-poisoned]
…ax_threads" `get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. [ghstack-poisoned]
…ax_threads" `get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. [ghstack-poisoned]
ngimel
approved these changes
Jun 22, 2021
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ax_threads" `get_num_threads` is usually called before `parallel_for` so there's no guaruntee we've initialized `num_threads` properly. Differential Revision: [D29287814](https://our.internmc.facebook.com/intern/diff/D29287814) [ghstack-poisoned]
|
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
get_num_threadsis usually called beforeparallel_forso there's noguaruntee we've initialized
num_threadsproperly.Differential Revision: D29287814