Fix FFT documentation examples and run doctests in the test suite #60304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 4226688 (more details on the Dr. CI page and at hud.pytorch.org/pr/60304):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
mruberry
approved these changes
Jun 20, 2021
There was a problem hiding this comment.
Cool! Thanks @peterbell10.
cc @pmeier, this is another good datapoint that maybe we should default check_strides to False
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@peterbell10 when #60637 is landed, you can drop the |
pmeier
added a commit
that referenced
this pull request
Jun 24, 2021
We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: #58981 (comment) - `torchvision` test suite: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: #60304 (review) Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jun 24, 2021
We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: #58981 (comment) - `torchvision` test suite: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: #60304 (review) Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 1, 2021
We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: #58981 (comment) - `torchvision` test suite: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: #60304 (review) Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. [ghstack-poisoned]
pmeier
added a commit
that referenced
this pull request
Jul 1, 2021
We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: #58981 (comment) - `torchvision` test suite: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: #60304 (review) Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
Summary: Pull Request resolved: #60637 We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: #58981 (comment) - `torchvision` test suite: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: #60304 (review) Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D29556355 Pulled By: mruberry fbshipit-source-id: 0029a44280d8f4369fbdb537dce3202eeee4b1d9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59514