Don't check stride by default #60637
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have three out of three datapoints that `check_stride` will be `partial`'ed to `False`: - `torch`: #58981 (comment) - `torchvision`: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit d7258e3 (more details on the Dr. CI page and at hud.pytorch.org/pr/60637): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 24, 2021
pmeier
added
the
module: testing
We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: #58981 (comment) - `torchvision` test suite: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: #60304 (review) Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. [ghstack-poisoned]
We now have ~three out of three~ four out of four datapoints that `check_stride` will be `partial`'ed to `False`: - `torch` test suite: #58981 (comment) - `torchvision` test suite: #56544 (comment) - `kornia`: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25 - `torch.fft`: #60304 (review) Given that the strides in most cases are in implementation detail, IMO we should change the default to `False`. In cases were matching strides is a requirement for closeness / equality it can always set to `True` manually. [ghstack-poisoned]
mruberry
approved these changes
Jul 6, 2021
|
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
msgintorch.testing.assert_close#60254 tests for diagnostics in callablemsgintorch.testing.assert_closetorch.testing.assert_close#60163 update docstring examples oftorch.testing.assert_closetorch.testing.assert_closein case of mismatching values #60091 Improve error messages oftorch.testing.assert_closein case of mismatching valuesWe now have
three out of threefour out of four datapoints thatcheck_stridewill bepartial'ed toFalse:torchtest suite: usetorch.testing.assert_closefor internal test suite #58981 (comment)torchvisiontest suite: Resolved: add torch.testing.assert_close() #56544 (comment)kornia: https://github.com/kornia/kornia/blob/9041c42b410e6a4bbb664c7134a120be80aa2265/test/utils.py#L25torch.fft: Fix FFT documentation examples and run doctests in the test suite #60304 (review)Given that the strides in most cases are in implementation detail, IMO we should change the default to
False. In cases were matching strides is a requirement for closeness / equality it can always set toTruemanually.Differential Revision: D29556355