KEMBAR78
use explicitly non-returning GPU atomics by jeffdaily · Pull Request #60607 · pytorch/pytorch · GitHub
Skip to content

use explicitly non-returning GPU atomics #60607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

use explicitly non-returning GPU atomics #60607

wants to merge 6 commits into from

Conversation

@jeffdaily
Copy link
Collaborator

Enables an important performance optimization for ROCm, in light of the discussion in #41028.

CC @jithunnair-amd @sunway513

@jeffdaily jeffdaily requested a review from ngimel June 23, 2021 23:19
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 23, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit de042d3 (more details on the Dr. CI page and at hud.pytorch.org/pr/60607):

  • 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/job-specs-custom.yml
Auto-merging .circleci/verbatim-sources/job-specs/job-specs-custom.yml
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
Auto-merging .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
CONFLICT (add/add): Merge conflict in .circleci/scripts/setup_ci_environment.sh
Auto-merging .circleci/scripts/setup_ci_environment.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result. 
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/job-specs/job-specs-custom.yml
Auto-merging .circleci/verbatim-sources/job-specs/job-specs-custom.yml
CONFLICT (add/add): Merge conflict in .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
Auto-merging .circleci/verbatim-sources/build-parameters/pytorch-build-params.yml
CONFLICT (add/add): Merge conflict in .circleci/scripts/setup_ci_environment.sh
Auto-merging .circleci/scripts/setup_ci_environment.sh
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/pytorch_build_definitions.py
Auto-merging .circleci/cimodel/data/pytorch_build_definitions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_macos_10_13_py3_test (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 28 18:30:12 RuntimeError: test_quantization failed! 
Jun 28 18:30:12 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.core.test_quantized_op.TestQNNPackOps-20210628182712.xml
Jun 28 18:30:12 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.fx.test_quantize_fx.TestQuantizeFx-20210628182712.xml
Jun 28 18:30:12 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.fx.test_quantize_fx.TestQuantizeFxOps-20210628182712.xml
Jun 28 18:30:12 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.eager.test_quantize_eager_ptq.TestQuantizeONNXExport-20210628182712.xml
Jun 28 18:30:12 Generated XML report: test-reports/dist-gloo/test_quantization/TEST-quantization.core.test_quantized_op.TestQuantizedEmbeddingOps-20210628182712.xml
Jun 28 18:30:12 Traceback (most recent call last):
Jun 28 18:30:12   File "test/run_test.py", line 1305, in <module>
Jun 28 18:30:12     main()
Jun 28 18:30:12   File "test/run_test.py", line 1284, in main
Jun 28 18:30:12     raise RuntimeError(err_message)
Jun 28 18:30:12 RuntimeError: test_quantization failed!
Jun 28 18:30:13 + cleanup
Jun 28 18:30:13 + retcode=1
Jun 28 18:30:13 + set +x


Exited with code exit status 1
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

ngimel
ngimel reviewed Jun 26, 2021
View reviewed changes
@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented Jun 26, 2021

Importing to see how internal builds go.

@jbschlosser jbschlosser added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 28, 2021
@facebook-github-bot
Copy link
Contributor

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jeffdaily jeffdaily mentioned this pull request Jun 28, 2021
Merged
@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in d36ce61.

jeffdaily added a commit to ROCm/pytorch that referenced this pull request Jun 29, 2021
@jeffdaily
use explicitly non-returning GPU atomics (pytorch#60607)
796c4d5 
Summary:
Enables an important performance optimization for ROCm, in light of the discussion in pytorch#41028.

CC jithunnair-amd sunway513

Pull Request resolved: pytorch#60607

Reviewed By: jbschlosser

Differential Revision: D29409894

Pulled By: ngimel

fbshipit-source-id: effca258a0f37eaefa35674a7fd19459ca7dc95b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffdaily @facebook-github-bot @ngimel @pytorchbot @jbschlosser