Sparse CSR: increase dtype test coverage #60656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses `torch.testing.get_all_dtypes()` for dtype parametrisation of tests in `test_sparse_csr.py`. It adds previously excluded from tests bool, half, bfloat16, complex dtypes. `torch.complex32` is omitted due to lack of coverage and lack of specialized `AT_DISPATCH...`. The process of adding more dtypes to tests releaved that `.to_dense()` doesn't work for all dtypes. [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 8f50055 (more details on the Dr. CI page and at hud.pytorch.org/pr/60656): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
IvanYashchuk
added
module: sparse
This PR uses `torch.testing.get_all_dtypes()` for dtype parametrisation of tests in `test_sparse_csr.py`. It adds previously excluded from tests bool, half, bfloat16, complex dtypes. `torch.complex32` is omitted due to lack of coverage and lack of specialized `AT_DISPATCH...`. The process of adding more dtypes to tests releaved that `.to_dense()` doesn't work for all dtypes. [ghstack-poisoned]
IvanYashchuk
commented
Jun 24, 2021
Comment on lines
+306
to
+310
| # TODO: https://github.com/pytorch/pytorch/issues/60648 | ||
| @dtypes(torch.bool, torch.half, torch.bfloat16, torch.complex64, torch.complex128) | ||
| @unittest.expectedFailure | ||
| def test_sparse_csr_to_dense_xfail(self, device, dtype): | ||
| _run_test_sparse_csr_to_dense(device, dtype) |
There was a problem hiding this comment.
The next PR in the stack fixes that.
IvanYashchuk
added a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Jun 24, 2021
This PR uses `torch.testing.get_all_dtypes()` for dtype parametrisation of tests in `test_sparse_csr.py`. It adds previously excluded from tests bool, half, bfloat16, complex dtypes. `torch.complex32` is omitted due to lack of coverage and lack of specialized `AT_DISPATCH...`. The process of adding more dtypes to tests releaved that `.to_dense()` doesn't work for all dtypes. ghstack-source-id: 70b1378 Pull Request resolved: pytorch#60656
|
Btw, you probably wanted master to be the base :) |
|
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
The base branch is autogenerated by https://github.com/ezyang/ghstack |
|
@cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
asuhan
pushed a commit
to asuhan/pytorch
that referenced
this pull request
Jun 28, 2021
Summary: Pull Request resolved: pytorch#60656 This PR uses `torch.testing.get_all_dtypes()` for dtype parametrisation of tests in `test_sparse_csr.py`. It adds previously excluded from tests bool, half, bfloat16, complex dtypes. `torch.complex32` is omitted due to lack of coverage and lack of specialized `AT_DISPATCH...`. The process of adding more dtypes to tests releaved that `.to_dense()` doesn't work for all dtypes. Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D29408058 Pulled By: cpuhrsch fbshipit-source-id: 319b6f51b9786d6957d508f51657657a6d00267a
asuhan
pushed a commit
that referenced
this pull request
Jun 30, 2021
Summary: Pull Request resolved: #60656 This PR uses `torch.testing.get_all_dtypes()` for dtype parametrisation of tests in `test_sparse_csr.py`. It adds previously excluded from tests bool, half, bfloat16, complex dtypes. `torch.complex32` is omitted due to lack of coverage and lack of specialized `AT_DISPATCH...`. The process of adding more dtypes to tests releaved that `.to_dense()` doesn't work for all dtypes. Test Plan: Imported from OSS Reviewed By: ngimel Differential Revision: D29408058 Pulled By: cpuhrsch fbshipit-source-id: 319b6f51b9786d6957d508f51657657a6d00267a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR uses
torch.testing.get_all_dtypes()for dtype parametrisationof tests in
test_sparse_csr.py. It adds previously excluded from testsbool, half, bfloat16, complex dtypes.
torch.complex32is omitted dueto lack of coverage and lack of specialized
AT_DISPATCH....The process of adding more dtypes to tests releaved that
.to_dense()doesn't work for all dtypes.
Differential Revision: D29408058