KEMBAR78
[package] typing.io/re edge case hack by Lilyjjo · Pull Request #60666 · pytorch/pytorch · GitHub
Skip to content

[package] typing.io/re edge case hack #60666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[package] typing.io/re edge case hack #60666

wants to merge 2 commits into from

Conversation

@Lilyjjo
Copy link
Contributor

@Lilyjjo Lilyjjo commented Jun 24, 2021 •
edited
Loading

Stack from ghstack:

Not a cursed PR, despite the number!

Adds hack for importing typing.io/re same as importing os/os.path, issue described here: #57490

Differential Revision: D29367847

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 24, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit b14ccd8 (more details on the Dr. CI page and at hud.pytorch.org/pr/60666):

  • 4/4 failures introduced in this PR

🕵️ 4 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/4)

Step: "Report results" (full log | diagnosis details | 🔁 rerun)

Jun 24 18:47:21 python: can't open file 'tools/...est_stats.py': [Errno 2] No such file or directory 
Jun 24 18:47:21 + export CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 18:47:21 + CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 18:47:21 + export JOB_BASE_NAME=pytorch_linux_backward_compatibility_check_test
Jun 24 18:47:21 + JOB_BASE_NAME=pytorch_linux_backward_compatibility_check_test
Jun 24 18:47:21 + export CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 18:47:21 + CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 18:47:21 + cd workspace
Jun 24 18:47:21 + export PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 18:47:21 + PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 18:47:21 + python tools/print_test_stats.py --upload-to-s3 --compare-with-s3 test
Jun 24 18:47:21 python: can't open file 'tools/print_test_stats.py': [Errno 2] No such file or directory


Exited with code exit status 2

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_test (2/4)

Step: "Report results" (full log | diagnosis details | 🔁 rerun)

Jun 24 20:12:42 python: can't open file 'tools/...est_stats.py': [Errno 2] No such file or directory 
Jun 24 20:12:42 + export CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 20:12:42 + CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 20:12:42 + export JOB_BASE_NAME=pytorch_xla_linux_bionic_py3_6_clang9_test
Jun 24 20:12:42 + JOB_BASE_NAME=pytorch_xla_linux_bionic_py3_6_clang9_test
Jun 24 20:12:42 + export CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 20:12:42 + CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 20:12:42 + cd workspace
Jun 24 20:12:42 + export PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 20:12:42 + PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 20:12:42 + python tools/print_test_stats.py --upload-to-s3 --compare-with-s3 test
Jun 24 20:12:42 python: can't open file 'tools/print_test_stats.py': [Errno 2] No such file or directory


Exited with code exit status 2

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (3/4)

Step: "Report results" (full log | diagnosis details | 🔁 rerun)

Jun 24 20:32:51 python: can't open file 'tools/...est_stats.py': [Errno 2] No such file or directory 
Jun 24 20:32:51 + export CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 20:32:51 + CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 20:32:51 + export JOB_BASE_NAME=pytorch_linux_xenial_py3_6_gcc5_4_test
Jun 24 20:32:51 + JOB_BASE_NAME=pytorch_linux_xenial_py3_6_gcc5_4_test
Jun 24 20:32:51 + export CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 20:32:51 + CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 20:32:51 + cd workspace
Jun 24 20:32:51 + export PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 20:32:51 + PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 20:32:51 + python tools/print_test_stats.py --upload-to-s3 --compare-with-s3 test
Jun 24 20:32:51 python: can't open file 'tools/print_test_stats.py': [Errno 2] No such file or directory


Exited with code exit status 2

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_jit_legacy_test (4/4)

Step: "Report results" (full log | diagnosis details | 🔁 rerun)

Jun 24 18:46:47 python: can't open file 'tools/...est_stats.py': [Errno 2] No such file or directory 
Jun 24 18:46:47 + export CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 18:46:47 + CIRCLE_BRANCH=gh/Lilyjjo/90/head
Jun 24 18:46:47 + export JOB_BASE_NAME=pytorch_linux_xenial_py3_6_gcc5_4_jit_legacy_test
Jun 24 18:46:47 + JOB_BASE_NAME=pytorch_linux_xenial_py3_6_gcc5_4_jit_legacy_test
Jun 24 18:46:47 + export CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 18:46:47 + CIRCLE_WORKFLOW_ID=21251b4e-f9b2-4ef5-9b9f-08e3f30ce336
Jun 24 18:46:47 + cd workspace
Jun 24 18:46:47 + export PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 18:46:47 + PYTHONPATH=/var/lib/jenkins/workspace
Jun 24 18:46:47 + python tools/print_test_stats.py --upload-to-s3 --compare-with-s3 test
Jun 24 18:46:47 python: can't open file 'tools/print_test_stats.py': [Errno 2] No such file or directory


Exited with code exit status 2
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Lilyjjo added a commit that referenced this pull request Jun 24, 2021
@Lilyjjo
[package] typing.io/re edge case hack
38faba9 
ghstack-source-id: fca30d2
Pull Request resolved: #60666
@Lilyjjo Lilyjjo requested a review from suo June 24, 2021 17:32
Lilyjjo added a commit that referenced this pull request Jun 24, 2021
@Lilyjjo
[package] typing.io/re edge case hack
7d0666e 
ghstack-source-id: 424b2f0
Pull Request resolved: #60666
@Lilyjjo
Copy link
Contributor Author

Lilyjjo commented Jun 24, 2021

@Lilyjjo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

suo
suo approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@suo suo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@facebook-github-bot
Copy link
Contributor

@Lilyjjo merged this pull request in fe4ded0.

@facebook-github-bot facebook-github-bot deleted the gh/Lilyjjo/90/head branch June 28, 2021 14:17
asuhan pushed a commit to asuhan/pytorch that referenced this pull request Jun 28, 2021
@Lilyjjo @asuhan
[package] typing.io/re edge case hack (pytorch#60666)
4963f80 
Summary: Pull Request resolved: pytorch#60666

Test Plan: Imported from OSS

Reviewed By: suo

Differential Revision: D29367847

Pulled By: Lilyjjo

fbshipit-source-id: 2c38140fbb3eab61ae3de60ab475243f0338c547
asuhan pushed a commit that referenced this pull request Jun 30, 2021
@Lilyjjo @asuhan
[package] typing.io/re edge case hack (#60666)
7103077 
Summary: Pull Request resolved: #60666

Test Plan: Imported from OSS

Reviewed By: suo

Differential Revision: D29367847

Pulled By: Lilyjjo

fbshipit-source-id: 2c38140fbb3eab61ae3de60ab475243f0338c547
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo suo approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lilyjjo @facebook-github-bot @suo