KEMBAR78
[test] Run parallel clang-tidy on codebase (failure expected) by 1ntEgr8 · Pull Request #60871 · pytorch/pytorch · GitHub
Skip to content

[test] Run parallel clang-tidy on codebase (failure expected) #60871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[test] Run parallel clang-tidy on codebase (failure expected) #60871

wants to merge 2 commits into from

Conversation

@1ntEgr8
Copy link
Contributor

@1ntEgr8 1ntEgr8 commented Jun 28, 2021 •
edited
Loading

Stack from ghstack:

This was referenced Jun 28, 2021
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 0f5014b (more details on the Dr. CI page and at hud.pytorch.org/pr/60871):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Lint / clang-tidy (1/1)

Step: "Run clang-tidy" (full log | diagnosis details | 🔁 rerun)

2021-06-28T18:31:52.4719462Z /__w/pytorch/pytor...d identifier 'GTEST_SKIP' [clang-diagnostic-error] 
2021-06-28T18:31:52.4713110Z ^
2021-06-28T18:31:52.4713759Z ../cmake/../third_party/googletest/googletest/include/gtest/gtest.h:2287:42: note: expanded from macro 'TEST'
2021-06-28T18:31:52.4714458Z # define TEST(test_case_name, test_name) GTEST_TEST(test_case_name, test_name)
2021-06-28T18:31:52.4714893Z                                          ^
2021-06-28T18:31:52.4715582Z ../cmake/../third_party/googletest/googletest/include/gtest/gtest.h:2281:3: note: expanded from macro 'GTEST_TEST'
2021-06-28T18:31:52.4716193Z   GTEST_TEST_(test_case_name, test_name, \
2021-06-28T18:31:52.4716509Z   ^
2021-06-28T18:31:52.4717266Z ../cmake/../third_party/googletest/googletest/include/gtest/internal/gtest-internal.h:1313:37: note: expanded from macro 'GTEST_TEST_'
2021-06-28T18:31:52.4718051Z   static ::testing::TestInfo* const test_info_ GTEST_ATTRIBUTE_UNUSED_;\
2021-06-28T18:31:52.4718494Z                                     ^
2021-06-28T18:31:52.4719462Z /__w/pytorch/pytorch/torch/csrc/deploy/test_deploy_gpu.cpp:26:5: error: use of undeclared identifier 'GTEST_SKIP' [clang-diagnostic-error]
2021-06-28T18:31:52.4720144Z     GTEST_SKIP();
2021-06-28T18:31:52.4720417Z     ^
2021-06-28T18:31:52.4720574Z 
2021-06-28T18:31:52.4720830Z stderr:
2021-06-28T18:31:52.4721161Z 12705 warnings and 1 error generated.
2021-06-28T18:31:52.4721723Z Error while processing /__w/pytorch/pytorch/torch/csrc/deploy/test_deploy_gpu.cpp.
2021-06-28T18:31:52.4722442Z Suppressed 13053 warnings (12697 in non-user code, 356 NOLINT).
2021-06-28T18:31:52.4723387Z Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
2021-06-28T18:31:52.4724089Z Found compiler error(s).
2021-06-28T18:31:52.4724306Z
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

1ntEgr8 added a commit that referenced this pull request Jun 28, 2021
@1ntEgr8
[test] Run parallel clang-tidy on codebase (failure expected)
86b88ab 
ghstack-source-id: aa03bbe
Pull Request resolved: #60871
@driazati
Copy link
Contributor

< 30 minutes for the whole codebase! looks like we'll be alright using the EC2 runners then

1ntEgr8 added a commit that referenced this pull request Jun 28, 2021
@1ntEgr8
Update on "Enable parallel clang-tidy on ec2 runner"
2fcf106 
This PR makes `clang-tidy` run on our self-hosted runner in a parallel fashion.

Fixes #60867
Test Plan: #60871

Differential Revision: [D29434240](https://our.internmc.facebook.com/intern/diff/D29434240)

[ghstack-poisoned]
1ntEgr8 added a commit that referenced this pull request Jun 28, 2021
@1ntEgr8
[test] Run parallel clang-tidy on codebase (failure expected)
5145a39 
ghstack-source-id: a77d832
Pull Request resolved: #60871
facebook-github-bot pushed a commit that referenced this pull request Jun 28, 2021
@1ntEgr8 @facebook-github-bot
Enable parallel clang-tidy on ec2 runner (#60870)
f5e5ced 
Summary:
Pull Request resolved: #60870

This PR makes `clang-tidy` run on our self-hosted runner in a parallel fashion.

Fixes #60867

Test Plan: #60871

Reviewed By: jbschlosser

Differential Revision: D29434240

Pulled By: 1ntEgr8

fbshipit-source-id: cead30ed718ddf5e14b13afe70cb209aa16b44a0
@1ntEgr8 1ntEgr8 closed this Jun 28, 2021
@facebook-github-bot facebook-github-bot deleted the gh/1ntEgr8/9/head branch July 29, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@1ntEgr8 @facebook-github-bot @driazati