KEMBAR78
Modify error message when atol=0 and rtol=0 by 1ntEgr8 · Pull Request #60897 · pytorch/pytorch · GitHub
Skip to content

Modify error message when atol=0 and rtol=0 #60897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Modify error message when atol=0 and rtol=0 #60897

wants to merge 4 commits into from

Conversation

@1ntEgr8
Copy link
Contributor

@1ntEgr8 1ntEgr8 commented Jun 28, 2021 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 6f69258 (more details on the Dr. CI page and at hud.pytorch.org/pr/60897):

  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (1/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jun 29 16:44:37 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Jun 29 16:44:37 ++++ extract_trap_cmd
Jun 29 16:44:37 ++++ printf '%s\n' ''
Jun 29 16:44:37 +++ printf '%s\n' cleanup
Jun 29 16:44:37 ++ trap -- '
Jun 29 16:44:37 cleanup' EXIT
Jun 29 16:44:37 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build != *pytorch-win-* ]]
Jun 29 16:44:37 ++ which sccache
Jun 29 16:44:37 ++ sccache --stop-server
Jun 29 16:44:37 ++ true
Jun 29 16:44:37 ++ rm /var/lib/jenkins/sccache_error.log
Jun 29 16:44:37 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory
Jun 29 16:44:37 ++ true
Jun 29 16:44:37 ++ [[ -n '' ]]
Jun 29 16:44:37 ++ [[ pytorch-linux-xenial-py3.6-gcc5.4-build == *rocm* ]]
Jun 29 16:44:37 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Jun 29 16:44:37 ++ SCCACHE_IDLE_TIMEOUT=1200
Jun 29 16:44:37 ++ RUST_LOG=sccache::server=error
Jun 29 16:44:37 ++ sccache --start-server
Jun 29 16:44:37 sccache: Starting the server...
Jun 29 16:44:37 ++ sccache --zero-stats
Jun 29 16:44:37 Compile requests                      0

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/2)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jun 29 16:42:02 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory 
Jun 29 16:42:02 ++++ extract_trap_cmd
Jun 29 16:42:02 ++++ printf '%s\n' ''
Jun 29 16:42:02 +++ printf '%s\n' cleanup
Jun 29 16:42:02 ++ trap -- '
Jun 29 16:42:02 cleanup' EXIT
Jun 29 16:42:02 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-build != *pytorch-win-* ]]
Jun 29 16:42:02 ++ which sccache
Jun 29 16:42:02 ++ sccache --stop-server
Jun 29 16:42:02 ++ true
Jun 29 16:42:02 ++ rm /var/lib/jenkins/sccache_error.log
Jun 29 16:42:02 rm: cannot remove '/var/lib/jenkins/sccache_error.log': No such file or directory
Jun 29 16:42:02 ++ true
Jun 29 16:42:02 ++ [[ -n '' ]]
Jun 29 16:42:02 ++ [[ pytorch-xla-linux-bionic-py3.6-clang9-build == *rocm* ]]
Jun 29 16:42:02 ++ SCCACHE_ERROR_LOG=/var/lib/jenkins/sccache_error.log
Jun 29 16:42:02 ++ SCCACHE_IDLE_TIMEOUT=1200
Jun 29 16:42:02 ++ RUST_LOG=sccache::server=error
Jun 29 16:42:02 ++ sccache --start-server
Jun 29 16:42:02 sccache: Starting the server...
Jun 29 16:42:02 ++ sccache --zero-stats
Jun 29 16:42:02 Compile requests                      0

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@1ntEgr8 1ntEgr8 mentioned this pull request Jun 28, 2021
Closed
@1ntEgr8 1ntEgr8 requested review from driazati and ezyang June 28, 2021 20:50
driazati
driazati approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@driazati driazati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

ezyang
ezyang approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOD this has been bugging me forever. Much appreciated.

@1ntEgr8
Copy link
Contributor Author

1ntEgr8 commented Jun 29, 2021

@1ntEgr8 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@1ntEgr8 merged this pull request in 5f51406.

@facebook-github-bot facebook-github-bot deleted the gh/1ntEgr8/10/head branch July 3, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

+1 more reviewer

@driazati driazati driazati approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@1ntEgr8 @facebook-github-bot @ezyang @driazati