KEMBAR78
update `unsafe` flag documentation by kazhou · Pull Request #60899 · pytorch/pytorch · GitHub
Skip to content

update unsafe flag documentation #60899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

update unsafe flag documentation #60899

wants to merge 2 commits into from

Conversation

@kazhou
Copy link
Contributor

@kazhou kazhou commented Jun 28, 2021 •
edited
Loading

Stack from ghstack:

modify documentation for unsafe flag in parametrize.py

Differential Revision: D29436688

@kazhou
update unsafe flag documentation
378d47c 
modify documentation for `unsafe` flag in `parametrize.py`

Differential Revision: [D29436688](https://our.internmc.facebook.com/intern/diff/D29436688/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 28, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit e02d2f4 (more details on the Dr. CI page and at hud.pytorch.org/pr/60899):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build Windows CI (pytorch-win-vs2019-cuda10-cudnn7-py3) / test (1) (1/1)

Step: "Run test scripts" (full log | diagnosis details | 🔁 rerun)

2021-06-28T22:38:11.6478245Z Build left local git repository checkout dirty 
2021-06-28T22:38:11.3693447Z + assert_git_not_dirty
2021-06-28T22:38:11.3694184Z + [[ pytorch-win-vs2019-cuda10-cudnn7-py3 != *rocm* ]]
2021-06-28T22:38:11.3695137Z + [[ pytorch-win-vs2019-cuda10-cudnn7-py3 != *xla* ]]
2021-06-28T22:38:11.3784943Z ++ git status --porcelain
2021-06-28T22:38:11.6473977Z + git_status='?? lazy_tensor_core/'
2021-06-28T22:38:11.6475134Z + [[ -n ?? lazy_tensor_core/ ]]
2021-06-28T22:38:11.6475996Z + echo 'Build left local git repository checkout dirty'
2021-06-28T22:38:11.6476798Z + echo 'git status --porcelain:'
2021-06-28T22:38:11.6477373Z + echo '?? lazy_tensor_core/'
2021-06-28T22:38:11.6477754Z + exit 1
2021-06-28T22:38:11.6478245Z Build left local git repository checkout dirty
2021-06-28T22:38:11.6478775Z git status --porcelain:
2021-06-28T22:38:11.6479217Z ?? lazy_tensor_core/
2021-06-28T22:38:11.6479917Z + cleanup
2021-06-28T22:38:11.6480501Z + retcode=1
2021-06-28T22:38:11.6480828Z + set +x
2021-06-28T22:38:11.6513457Z ##[error]Process completed with exit code 1.
2021-06-28T22:38:11.6690193Z ##[group]Run # -ir => recursive include all files in pattern
2021-06-28T22:38:11.6691012Z �[36;1m# -ir => recursive include all files in pattern�[0m
2021-06-28T22:38:11.6691671Z �[36;1m7z a "test-reports-$Env:TEST_CONFIG.zip" -ir'!test\*.xml'�[0m
2021-06-28T22:38:11.6721121Z shell: C:\Windows\System32\WindowsPowerShell\v1.0\powershell.EXE -command ". '{0}'"

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kazhou kazhou requested review from lezcano and z-a-f June 28, 2021 20:28
albanD
albanD approved these changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazhou
Update on "update unsafe flag documentation"
e02d2f4 
modify documentation for `unsafe` flag in `parametrize.py`

Differential Revision: [D29436688](https://our.internmc.facebook.com/intern/diff/D29436688/)

[ghstack-poisoned]
kazhou added a commit that referenced this pull request Jun 28, 2021
@kazhou
update unsafe flag documentation
eecc66b 
Pull Request resolved: #60899

modify documentation for `unsafe` flag in `parametrize.py`
ghstack-source-id: 132591862

Differential Revision: [D29436688](https://our.internmc.facebook.com/intern/diff/D29436688/)
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #60899 (e02d2f4) into gh/kazhou/1/base (41c380e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           gh/kazhou/1/base   #60899   +/-   ##
=================================================
  Coverage             76.21%   76.22%           
=================================================
  Files                  2064     2064           
  Lines                205634   205634           
=================================================
+ Hits                 156729   156737    +8     
+ Misses                48905    48897    -8

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4310044.

@facebook-github-bot facebook-github-bot deleted the gh/kazhou/1/head branch July 3, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

@z-a-f z-a-f Awaiting requested review from z-a-f

@lezcano lezcano Awaiting requested review from lezcano

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kazhou @facebook-github-bot @albanD