Add a test case for findDanglingImpls #61104
Conversation
Summary: This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information. Test Plan: python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 070d915 (more details on the Dr. CI page and at hud.pytorch.org/pr/61104):
ci.pytorch.org: 1 failedPreview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information. Test Plan: python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 7d30aa0 Pull Request resolved: #61104
|
@alanwaketan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This is a follow up for d5be67a. |
|
Oops, didn't know Windows uses '\' instead of '/'. (I guess I never need to deal with Windows in my previous job. 🤪) Will fix that. But I'm a little bit surprised by the Linux/CUDA failure. Not sure why it has two dangling implementations. |
Summary: This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information. Test Plan: python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29512520](https://our.internmc.facebook.com/intern/diff/D29512520) [ghstack-poisoned]
Summary: This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information. Test Plan: python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f43b6b8 Pull Request resolved: #61104
Thanks for approving this patch, Ed! However, wondering if you have any insights about the following CI failures:
Not sure why there is one more dangling impl. @ezyang |
|
well if you had printed the output of findDanglingImpls that would have given you a good clue right :) |
Thanks, Ed. That's right. It looks like the dangling implementation is unrelated to my patch. I just took a look at the full log. It indicates that there is one dangling implementation for the default test. Let me modify the default test case such that it always prints the info. |
Summary: This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information. Test Plan: python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29512520](https://our.internmc.facebook.com/intern/diff/D29512520) [ghstack-poisoned]
Summary: This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information. Test Plan: python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D29512520](https://our.internmc.facebook.com/intern/diff/D29512520) [ghstack-poisoned]
Summary: This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information. Test Plan: python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f191cd4 Pull Request resolved: #61104
|
@alanwaketan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 357c4d9. |
3 participants
Stack from ghstack:
Summary:
This patch added a new test case for findDanglingImpls. The test case introduces a C++ extension which has a dangling impl such that findDanglingImpls can find it and output its information.
Test Plan:
python test/test_dispatch.py TestDispatch.test_find_dangling_impls_ext
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D29512520