KEMBAR78
Add compare_set in distributed docs by H-Huang · Pull Request #61351 · pytorch/pytorch · GitHub
Skip to content

Add compare_set in distributed docs #61351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add compare_set in distributed docs #61351

wants to merge 1 commit into from

Conversation

@H-Huang
Copy link
Member

@H-Huang H-Huang commented Jul 7, 2021 •
edited
Loading

Stack from ghstack:

Accidentally missed adding this because I thought the functions under Store were auto documented.
image

Preview: https://docs-preview.pytorch.org/61351/distributed.html#torch.distributed.Store.compare_set

Differential Revision: D29588206

@facebook-github-bot facebook-github-bot added oncall: distributed Add this issue/PR to distributed oncall triage queue cla signed labels Jul 7, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 92f528e (more details on the Dr. CI page and at hud.pytorch.org/pr/61351):

  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-scanned failure(s)
  • 1/2 broken upstream at merge base e4c450a on Jul 07 from 6:31am to 12:32pm

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Preview docs built from this PR

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

H-Huang added a commit that referenced this pull request Jul 7, 2021
@H-Huang
Add compare_set in distributed docs
71c474a 
ghstack-source-id: 73f1043
Pull Request resolved: #61351
@H-Huang
Copy link
Member Author

H-Huang commented Jul 7, 2021

@H-Huang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mrshenli
mrshenli approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @H-Huang, could you please post a screenshot of the rendered page?

@facebook-github-bot
Copy link
Contributor

@H-Huang merged this pull request in cdc0276.

@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/27/head branch July 12, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

Assignees

No one assigned

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@H-Huang @facebook-github-bot @mrshenli