Raise error in CMake for CUDA <9.2 #61462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anything before CUDA 9.2 is not supported (see #36848), and perhaps not even that. Differential Revision: [D29637251](https://our.internmc.facebook.com/intern/diff/D29637251/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 36ccb92 (more details on the Dr. CI page and at hud.pytorch.org/pr/61462): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 Preview docs built from this PR This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
lw
added a commit
that referenced
this pull request
Jul 9, 2021
Anything before CUDA 9.2 is not supported (see #36848), and perhaps not even that. Differential Revision: [D29637251](https://our.internmc.facebook.com/intern/diff/D29637251/) ghstack-source-id: 133312018 Pull Request resolved: #61462
samestep
approved these changes
Jul 9, 2021
ngimel
approved these changes
Jul 9, 2021
|
Thanks for documenting this! |
malfet
reviewed
Jul 9, 2021
| if(CUDA_VERSION VERSION_LESS 9.0) | ||
| message(FATAL_ERROR "PyTorch requires CUDA 9.0 and above.") | ||
| if(CUDA_VERSION VERSION_LESS 9.2) | ||
| message(FATAL_ERROR "PyTorch requires CUDA 9.2 and above.") |
There was a problem hiding this comment.
Nit
Suggested change
| message(FATAL_ERROR "PyTorch requires CUDA 9.2 and above.") | |
| message(FATAL_ERROR "PyTorch requires CUDA 9.2 or above.") |
malfet
approved these changes
Jul 9, 2021
|
This pull request has been merged in c830db0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Anything before CUDA 9.2 is not supported (see #36848), and perhaps not even that.
Differential Revision: D29637251