Removed metadata.pkl file from PyTorch model #61760
Closed
+35
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
oncall: jit
💊 CI failures summary and remediationsAs of commit 6b8ac15 (more details on the Dr. CI page and at hud.pytorch.org/pr/61760): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
|
This pull request was exported from Phabricator. Differential Revision: D29702943 |
Summary: Append mobile_info.json and producer_info.json into extra_files and parse the jsons from “model_info.json” in onExitLoadModel.
Test Plan:
# Test On CC Scanner
**Test content with LOG(WARNING)**
{P428203000}
**Scuba Logger Output**
{F630871365}
{F630871358}
# Test On 3D Photo
**Test content with LOG(WARNING)**
{P428203712}
**Scuba Logger Output**
{F630744454}
Differential Revision: D29608014
fbshipit-source-id: 0e74e8b6b5e972762e79636a1c13d71b89c87a3f
Differential Revision: D29673184 fbshipit-source-id: e6a98cb36bb321b85929dacebd15e3b70913a303
Differential Revision: D29690702 fbshipit-source-id: fd6a3228c9a603481c49924fbe24422f9e8160c4
Summary: Pull Request resolved: pytorch#61760 Remove all code that related to metadata.pkl creation including creating metadata.pkl, converting data from extra/mobile_info.json and extra/producer_info.json to metadata.pkl file. Test Plan: ## Run buck commands: - `cd` into `fbcode` then `buck build //caffe2/caffe2/fb/init:init` - `cd` into `fbcode` then `buck build //caffe2/torch/fb/init:init` - `buck build //xplat/caffe2:torch_mobile_core` ## Export a PyTorch lite/mobile model - Run: `flow-cli canary users.xcheng16.pytorch_trainer.TestWorkflow --run-as-secure-group ai_mobile_platform --buck-target //fblearner/flow/projects/users/xcheng16:workflow` under `fbcode` on devserver. - Resulted Model: metadata.pkl no longer exist {F632063134} Reviewed By: guangy10 Differential Revision: D29702943 fbshipit-source-id: 57b9198f04e1e50830b8756bacfa2e650325739e
|
This pull request was exported from Phabricator. Differential Revision: D29702943 |
chloeyutianyi
force-pushed
the
export-D29702943
branch
from
f82b489 to
6b8ac15
Compare
|
This pull request has been merged in 4479aa8. |
guangy10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed metadata.pkl from PyTorch model and cleaned up all code for metadata.pkl creation.