Add generic join unit tests #61786
Closed
Add generic join unit tests #61786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
requested review from
H-Huang,
cbalioglu,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
facebook-github-bot
added
oncall: distributed
💊 CI failures summary and remediationsAs of commit a7e4496 (more details on the Dr. CI page and at hud.pytorch.org/pr/61786):
🕵️ 3 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 Windows CI (pytorch-win-vs2019-cpu-py3) / test (default, 1, 2, windows.4xlarge) |
Install Visual Studio 2019 toolchain | 🔁 rerun |
| Test tools / test |
Install dependencies | 🔁 rerun |
ci.pytorch.org: 1 failed
Preview docs built from this PR
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
[ghstack-poisoned]
|
@andwgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mrshenli
reviewed
Jul 19, 2021
There was a problem hiding this comment.
Do you need to add this new test file to https://github.com/pytorch/pytorch/blob/master/test/run_test.py to enable it?
This adds unit tests for the generic join context manager. ``` gpurun python test/distributed/algorithms/test_join.py ``` Differential Revision: [D29746646](https://our.internmc.facebook.com/intern/diff/D29746646) [ghstack-poisoned]
|
@andwgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mrshenli
approved these changes
Jul 19, 2021
| inputs = self.construct_uneven_inputs(BASE_NUM_INPUTS, OFFSET) | ||
| with _Join([allreducer], run_post_hooks=True): | ||
| for _ in inputs: | ||
| allreducer() |
There was a problem hiding this comment.
Would I be correct if I assume main hook would still run in this case? And compared to test_single_joinable, the only difference here is that test_single_joinable_post_hooks does not check main hook results? If so, does it make sense if we remove this test, as it seems test_single_joinable behaves exactly the same way and only differs in asserts?
There was a problem hiding this comment.
I have now made test_single_joinable_post_hooks() not run the main hooks.
| @require_n_gpus_for_nccl_backend( | ||
| WORLD_SIZE, BACKEND | ||
| ) | ||
| def test_single_joinable(self): |
There was a problem hiding this comment.
does it make sense to dedup test code with test_single_joinable_main_hooks?
There was a problem hiding this comment.
Yup, I factored the core logic out into a single _test_join_base() and now use that as the base for all tests.
| @require_n_gpus_for_nccl_backend( | ||
| WORLD_SIZE, BACKEND | ||
| ) | ||
| def test_multiple_joinables(self): |
There was a problem hiding this comment.
looks like this can also dedup with test_single_joinable_main_hooks by providing a list of hooks and expected results to a common function?
| allreducer = AllReducer(self.device, self.process_group) | ||
| inputs = self.construct_uneven_inputs(BASE_NUM_INPUTS, OFFSET) | ||
| allreduce_total = 0 | ||
| with self.assertRaises(RuntimeError): |
There was a problem hiding this comment.
Shall we check the error message is expected?
| ] | ||
| inputs = self.construct_uneven_inputs(BASE_NUM_INPUTS, OFFSET) | ||
| allreduce_total = 0 | ||
| with self.assertRaises(RuntimeError): |
This adds unit tests for the generic join context manager. ``` gpurun python test/distributed/algorithms/test_join.py ``` Differential Revision: [D29746646](https://our.internmc.facebook.com/intern/diff/D29746646) [ghstack-poisoned]
|
@andwgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This adds unit tests for the generic join context manager. ``` gpurun python test/distributed/algorithms/test_join.py ``` Differential Revision: [D29746646](https://our.internmc.facebook.com/intern/diff/D29746646) [ghstack-poisoned]
|
@andwgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This adds unit tests for the generic join context manager. ``` gpurun python test/distributed/algorithms/test_join.py ``` Differential Revision: [D29746646](https://our.internmc.facebook.com/intern/diff/D29746646) [ghstack-poisoned]
This adds unit tests for the generic join context manager. ``` gpurun python test/distributed/algorithms/test_join.py ``` Differential Revision: [D29746646](https://our.internmc.facebook.com/intern/diff/D29746646) [ghstack-poisoned]
|
@andwgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This adds unit tests for the generic join context manager.
Differential Revision: D29746646