[OpInfo] Added ReductionOpInfo subclass of OpInfo and ported sum test #62737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e0c2b92 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Aug 6, 2021
[ghstack-poisoned]
[ghstack-poisoned]
heitorschueroff
changed the title
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
mruberry
reviewed
Aug 11, 2021
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
…ed sum test" [ghstack-poisoned]
mruberry
reviewed
Aug 18, 2021
mruberry
approved these changes
Aug 18, 2021
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 [ghstack-poisoned]
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ed sum test" ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as `max` and `min` that return multiple tensors and `quantile` that can return multiple values. fixes #49746 Differential Revision: [D30406568](https://our.internmc.facebook.com/intern/diff/D30406568) [ghstack-poisoned]
|
@heitorschueroff has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@heitorschueroff merged this pull request in 774ae08. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
ReductionOpInfo is a specialization of OpInfo for reduction operators. For now, it is designed to work with reductions that return a single tensor and that reduce all elements along one or more dimensions to a single value. In particular this excludes operators such as
maxandminthat return multiple tensors andquantilethat can return multiple values.fixes #49746
Differential Revision: D30406568