[reland] Gate DistributedOptimizers on RPC availability #62937
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reland due to windows + cuda failure, fix by running it on gloo on windows even with cuda. Differential Revision: [D30177734](https://our.internmc.facebook.com/intern/diff/D30177734/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D30177734/)! [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
wayi1 and
zhaojuanmao
as code owners
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 60b1314 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Aug 7, 2021
reland due to windows + cuda failure, fix by running it on gloo on windows even with cuda. Differential Revision: [D30177734](https://our.internmc.facebook.com/intern/diff/D30177734/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D30177734/)! ghstack-source-id: 135306176 Pull Request resolved: #62937
|
ci-all: #62938 |
|
This pull request has been merged in 39ec1da. |
alanwaketan
pushed a commit
that referenced
this pull request
Aug 17, 2021
Summary: Pull Request resolved: #62937 reland due to windows + cuda failure, fix by running it on gloo on windows even with cuda. ghstack-source-id: 135306176 Test Plan: ci Reviewed By: mrshenli Differential Revision: D30177734 fbshipit-source-id: 7625746984c8f858648c1b3632394b98bd4518d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
reland due to windows + cuda failure, fix by running it on gloo on windows even with cuda.
Differential Revision: D30177734
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!