clean up engine.cpp thread state #63115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c83a5a7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Aug 11, 2021
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
soulitzer
approved these changes
Aug 13, 2021
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
albanD
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Aug 17, 2021
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread (both for vanilla and distributed engine) ghstack-source-id: 28bc101 Pull Request resolved: pytorch#63115
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread [ghstack-poisoned]
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread Differential Revision: [D30388100](https://our.internmc.facebook.com/intern/diff/D30388100) [ghstack-poisoned]
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread Differential Revision: [D30388100](https://our.internmc.facebook.com/intern/diff/D30388100) [ghstack-poisoned]
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread Differential Revision: [D30388100](https://our.internmc.facebook.com/intern/diff/D30388100) [ghstack-poisoned]
This actually changes: - callbacks now run with proper grad mode even in worker threads - graphtask's Future callbacks now run with proper TLS when erroring out from a worker thread Differential Revision: [D30388100](https://our.internmc.facebook.com/intern/diff/D30388100) [ghstack-poisoned]
|
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This actually changes:
out from a worker thread
Differential Revision: D30388100