-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Add copy button to code snippets in docs #63149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 0d0cab7 (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
docs/cpp/source/conf.py
Outdated
| # If your documentation needs a minimal Sphinx version, state it here. | ||
| # | ||
| needs_sphinx = '1.6' | ||
| needs_sphinx = '1.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have 3.5.4 in the requirements.txt. Why not use that here?
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@anjali411 merged this pull request in 045c4cb. |
Summary: Pull Request resolved: #63149 Test Plan: Imported from OSS Reviewed By: navahgar, albanD Differential Revision: D30308891 Pulled By: anjali411 fbshipit-source-id: ad51180ab2f27c4525682b2603bbf753bb8f1ce9
Stack from ghstack:
Differential Revision: D30308891