KEMBAR78
Add copy button to code snippets in docs by anjali411 · Pull Request #63149 · pytorch/pytorch · GitHub
Skip to content

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented Aug 12, 2021

Stack from ghstack:

Differential Revision: D30308891

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 12, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 0d0cab7 (more details on the Dr. CI page):


  • 1/2 failures introduced in this PR
  • 1/2 broken upstream at merge base eea52b7 on Aug 12 from 12:38am to 3:26pm

1 failure not recognized by patterns:

Job Step Action
GitHub Actions win-vs2019-cuda10-cudnn7-py3 / render_test_results (default) Checkout PyTorch 🔁 rerun

1 job timed out:

  • pytorch_linux_xenial_py3_clang7_asan_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

anjali411 added a commit that referenced this pull request Aug 12, 2021
ghstack-source-id: 096094b
Pull Request resolved: #63149
@anjali411 anjali411 requested review from albanD and seemethere August 12, 2021 19:01
anjali411 added a commit that referenced this pull request Aug 12, 2021
ghstack-source-id: 90ad72a
Pull Request resolved: #63149
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

# If your documentation needs a minimal Sphinx version, state it here.
#
needs_sphinx = '1.6'
needs_sphinx = '1.8'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have 3.5.4 in the requirements.txt. Why not use that here?

anjali411 added a commit that referenced this pull request Aug 13, 2021
ghstack-source-id: d86837f
Pull Request resolved: #63149
@anjali411
Copy link
Contributor Author

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

@anjali411 merged this pull request in 045c4cb.

alanwaketan pushed a commit that referenced this pull request Aug 17, 2021
Summary: Pull Request resolved: #63149

Test Plan: Imported from OSS

Reviewed By: navahgar, albanD

Differential Revision: D30308891

Pulled By: anjali411

fbshipit-source-id: ad51180ab2f27c4525682b2603bbf753bb8f1ce9
@facebook-github-bot facebook-github-bot deleted the gh/anjali411/132/head branch August 18, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants