KEMBAR78
[docs] Merge note block in `torch.lu` documentation by SplitInfinity · Pull Request #63156 · pytorch/pytorch · GitHub
Skip to content

Conversation

@SplitInfinity
Copy link

@SplitInfinity SplitInfinity commented Aug 12, 2021

Stack from ghstack:

Summary
This commit merges the four successive Note blocks that appear in the
documentation for torch.lu. Each one only has one line in it, so all
of them have been merged into one block with a bulleted list that
contains the original items.

Test Plan
Continuous integration.

Before
Captura de Pantalla 2021-08-12 a la(s) 10 48 39 a  m

After
Captura de Pantalla 2021-08-12 a la(s) 10 48 46 a  m

Fixes
This commit fixes #62339.

Differential Revision: D30292633

**Summary**
This commit merges the four successive `Note` blocks that appear in the
documentation for `torch.lu`. Each one only has one line in it, so all
of them have been merged into one block with a bulleted list that
contains the original items.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #62339.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 12, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 6440bbf (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

SplitInfinity pushed a commit that referenced this pull request Aug 12, 2021
**Summary**
This commit merges the four successive `Note` blocks that appear in the
documentation for `torch.lu`. Each one only has one line in it, so all
of them have been merged into one block with a bulleted list that
contains the original items.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #62339.

ghstack-source-id: 44ffaf9
Pull Request resolved: #63156
@SplitInfinity
Copy link
Author

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@SplitInfinity SplitInfinity requested a review from zou3519 August 13, 2021 18:43
@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in acdad8b.

alanwaketan pushed a commit that referenced this pull request Aug 17, 2021
Summary:
Pull Request resolved: #63156

**Summary**
This commit merges the four successive `Note` blocks that appear in the
documentation for `torch.lu`. Each one only has one line in it, so all
of them have been merged into one block with a bulleted list that
contains the original items.

**Test Plan**
Continuous integration.

*Before*
<img width="888" alt="Captura de Pantalla 2021-08-12 a la(s) 10 48 39 a  m" src="https://user-images.githubusercontent.com/4392003/129244443-b7d1594e-8833-4c20-a911-e1bf7ca88a8d.png">

*After*
<img width="932" alt="Captura de Pantalla 2021-08-12 a la(s) 10 48 46 a  m" src="https://user-images.githubusercontent.com/4392003/129244462-1f39dcdb-90e0-4fd9-a95f-343b0b6be1f1.png">

**Fixes**
This commit fixes #62339.

Test Plan: Imported from OSS

Reviewed By: navahgar, pbelevich

Differential Revision: D30292633

Pulled By: SplitInfinity

fbshipit-source-id: cb9071165629bfe7316b1d2fe952e4354c75d48f
@facebook-github-bot facebook-github-bot deleted the gh/splitinfinity/158/head branch August 17, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants