KEMBAR78
[docs] Remove `input` parameter from `Tensor.flatten` docs by SplitInfinity · Pull Request #63180 · pytorch/pytorch · GitHub
Skip to content

Conversation

@SplitInfinity
Copy link

@SplitInfinity SplitInfinity commented Aug 12, 2021

Stack from ghstack:

Summary
This commit removes the input parameter from the signature for
Tensor.flatten shown in its documentation. This parameter is accepted
by torch.flatten but not Tensor.flatten (since the input is the
Tensor on which flatten is invoked).

Test Plan
Continuous integration.

Fixes
This commit fixes #57478.

Differential Revision: D30293156

**Summary**
This commit removes the `input` parameter from the signature for
`Tensor.flatten` shown in its documentation. This parameter is accepted
by `torch.flatten` but not `Tensor.flatten` (since the input is the
`Tensor` on which `flatten` is invoked).

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #57478.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 12, 2021

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e30f8ee (more details on the Dr. CI page):


  • 4/4 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang7_asan_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Aug 12 21:42:39 SUMMARY: UndefinedBehaviorSanit.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in
Aug 12 21:42:39     #4 0x5619e705b15f  (/opt/conda/bin/python3.6+0x13015f)
Aug 12 21:42:39     #5 0x5619e709d8f2  (/opt/conda/bin/python3.6+0x1728f2)
Aug 12 21:42:39     #6 0x5619e7105cd5  (/opt/conda/bin/python3.6+0x1dacd5)
Aug 12 21:42:39     #7 0x5619e7107d5d  (/opt/conda/bin/python3.6+0x1dcd5d)
Aug 12 21:42:39     #8 0x5619e7107dbb  (/opt/conda/bin/python3.6+0x1dcdbb)
Aug 12 21:42:39     #9 0x5619e7108926  (/opt/conda/bin/python3.6+0x1dd926)
Aug 12 21:42:39     #10 0x5619e7042196  (/opt/conda/bin/python3.6+0x117196)
Aug 12 21:42:39     #11 0x7f9f325c383f  (/lib/x86_64-linux-gnu/libc.so.6+0x2083f)
Aug 12 21:42:39     #12 0x5619e70d233d  (/opt/conda/bin/python3.6+0x1a733d)
Aug 12 21:42:39 
Aug 12 21:42:39 SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
Aug 12 21:42:39 + retcode=1
Aug 12 21:42:39 + set -e
Aug 12 21:42:39 + return 1
Aug 12 21:42:39 + [[ pytorch-linux-xenial-py3-clang7-asan-test1 == *-NO_AVX-* ]]
Aug 12 21:42:39 + [[ '' == \n\o\g\p\u\_\N\O\_\A\V\X ]]
Aug 12 21:42:39 + [[ pytorch-linux-xenial-py3-clang7-asan-test1 == *-NO_AVX2-* ]]
Aug 12 21:42:39 + [[ '' == \n\o\g\p\u\_\N\O\_\A\V\X\2 ]]
Aug 12 21:42:39 + [[ pytorch-linux-xenial-py3-clang7-asan-test1 == *-NO_AVX512-* ]]
Aug 12 21:42:39 + [[ '' == \n\o\g\p\u\_\N\O\_\A\V\X\5\1\2 ]]
Aug 12 21:42:39 + '[' -n https://github.com/pytorch/pytorch/pull/63180 ']'

3 failures not recognized by patterns:

Job Step Action
GitHub Actions linux-xenial-py3.6-gcc7-bazel-test / calculate-docker-image Checkout PyTorch 🔁 rerun
GitHub Actions linux-xenial-py3.6-gcc7-bazel-test / render_test_results Download PyTorch Test Reports 🔁 rerun
CircleCI pytorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_test2 Set Up CI Environment After attach_workspace 🔁 rerun

1 job timed out:

  • pytorch_linux_xenial_py3_clang7_asan_test1

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

SplitInfinity pushed a commit that referenced this pull request Aug 12, 2021
**Summary**
This commit removes the `input` parameter from the signature for
`Tensor.flatten` shown in its documentation. This parameter is accepted
by `torch.flatten` but not `Tensor.flatten` (since the input is the
`Tensor` on which `flatten` is invoked).

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #57478.

ghstack-source-id: fa37724
Pull Request resolved: #63180
@SplitInfinity
Copy link
Author

@SplitInfinity has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in e5c32cd.

alanwaketan pushed a commit that referenced this pull request Aug 17, 2021
Summary:
Pull Request resolved: #63180

**Summary**
This commit removes the `input` parameter from the signature for
`Tensor.flatten` shown in its documentation. This parameter is accepted
by `torch.flatten` but not `Tensor.flatten` (since the input is the
`Tensor` on which `flatten` is invoked).

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #57478.

Test Plan: Imported from OSS

Reviewed By: VitalyFedyunin

Differential Revision: D30293156

Pulled By: SplitInfinity

fbshipit-source-id: 4ad70d638af009fb6bdeb703433b306904d39a76
@facebook-github-bot facebook-github-bot deleted the gh/splitinfinity/160/head branch August 17, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants