clarify that torch.finfo.tiny is the smallest normal number
#63241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit fd4013a (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ber" This is a common source of confusion, but it matches the NumPy behavior. Fixes #44010 Fixes #59526 Differential Revision: [D30307646](https://our.internmc.facebook.com/intern/diff/D30307646) [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Aug 13, 2021
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mruberry
reviewed
Aug 17, 2021
thanks! |
…ber" This is a common source of confusion, but it matches the NumPy behavior. Fixes #44010 Fixes #59526 Differential Revision: [D30307646](https://our.internmc.facebook.com/intern/diff/D30307646) [ghstack-poisoned]
dagitses
pushed a commit
that referenced
this pull request
Aug 18, 2021
|
@dagitses has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.finfo.tinyis the smallest normal number #63241This is a common source of confusion, but it matches the NumPy
behavior.
Fixes #44010
Fixes #59526
Differential Revision: D30307646