Make operation call accept Stack& instead of Stack* #63414
Closed
+451
−409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
oncall: jit
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7147a02 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zhxchen17
changed the title
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
zhxchen17
requested review from
H-Huang,
cbalioglu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma,
wayi1 and
zhaojuanmao
as code owners
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
SplitInfinity
approved these changes
Aug 17, 2021
SplitInfinity
suggested changes
Aug 18, 2021
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
zhxchen17
commented
Aug 18, 2021
|
|
||
| class Operation { | ||
| public: | ||
| template <typename F, |
There was a problem hiding this comment.
Update: Made this diff API compatible with registration.
Instead of switching over to Stack&, we can just add another constructor for Operation, such that it can take both Stack* and Stack& callback. For Stack* constructor we can make it explicit that it's deprecated, which shouldn't be a hard break for users.
Note that we wrap another level of lambda for Stack* callback to make the implementation uniform, which may have performance overhead but we can take it as a forcing factor for users to switch to Stack& callback. (or it can be inlined, I don't know).
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
|
@zhxchen17 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Aug 27, 2021
Pull Request resolved: #63414 Misuse of raw pointer in here where stack is never nullable. Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410/) ghstack-source-id: 136834416
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
Summary: Misuse of raw pointer in here where stack is never nullable. Test Plan: compiles. Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410) [ghstack-poisoned]
zhxchen17
added a commit
that referenced
this pull request
Aug 29, 2021
Pull Request resolved: #63414 Misuse of raw pointer in here where stack is never nullable. ghstack-source-id: 136938318 Differential Revision: [D30375410](https://our.internmc.facebook.com/intern/diff/D30375410/)
facebook-github-bot
pushed a commit
to pytorch/vision
that referenced
this pull request
Aug 30, 2021
Summary: Pull Request resolved: pytorch/pytorch#63414 Misuse of raw pointer in here where stack is never nullable. ghstack-source-id: 136938318 Reviewed By: ejguan Differential Revision: D30375410 fbshipit-source-id: 9d65b620bb76d90d886c800f54308520095d58ee
|
This pull request has been merged in ac99d63. |
datumbox
pushed a commit
to datumbox/vision
that referenced
this pull request
Sep 7, 2021
…#63414) Summary: Pull Request resolved: pytorch/pytorch#63414 Misuse of raw pointer in here where stack is never nullable. ghstack-source-id: 136938318 Reviewed By: ejguan Differential Revision: D30375410 fbshipit-source-id: 9d65b620bb76d90d886c800f54308520095d58ee
kazhang
pushed a commit
to pytorch/vision
that referenced
this pull request
Sep 7, 2021
…#63414) (#4380) Summary: Pull Request resolved: pytorch/pytorch#63414 Misuse of raw pointer in here where stack is never nullable. ghstack-source-id: 136938318 Reviewed By: ejguan Differential Revision: D30375410 fbshipit-source-id: 9d65b620bb76d90d886c800f54308520095d58ee Co-authored-by: Zhengxu Chen <zhxchen17@fb.com>
tugsbayasgalan
changed the title
jjsjann123
pushed a commit
to jjsjann123/nvfuser
that referenced
this pull request
Oct 29, 2022
Summary: Pull Request resolved: pytorch/pytorch#63414 Misuse of raw pointer in here where stack is never nullable. ghstack-source-id: 136938318 Test Plan: compiles. Imported from OSS Reviewed By: ejguan Differential Revision: D30375410 fbshipit-source-id: 9d65b620bb76d90d886c800f54308520095d58ee
jjsjann123
pushed a commit
to jjsjann123/nvfuser
that referenced
this pull request
Nov 10, 2022
Summary: Pull Request resolved: pytorch/pytorch#63414 Misuse of raw pointer in here where stack is never nullable. ghstack-source-id: 136938318 Test Plan: compiles. Imported from OSS Reviewed By: ejguan Differential Revision: D30375410 fbshipit-source-id: 9d65b620bb76d90d886c800f54308520095d58ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Misuse of raw pointer in here where stack is never nullable.
Test Plan:
compiles.
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D30375410