KEMBAR78
Kill THCUNN by peterbell10 · Pull Request #63429 · pytorch/pytorch · GitHub
Skip to content

Kill THCUNN #63429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Kill THCUNN #63429

wants to merge 7 commits into from

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Aug 17, 2021 •
edited by ngimel
Loading

@peterbell10
Kill THCUNN
175f09b 
[ghstack-poisoned]
@peterbell10 peterbell10 mentioned this pull request Aug 17, 2021
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit bb05063 (more details on the Dr. CI page):

  • 6/6 failures possibly* introduced in this PR
    • 1/6 non-scanned failure(s)

🕵️ 4 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-cuda11.1-py3.6-gcc7 / test (default, 1, 2, linux.8xlarge.nvidia.gpu) (1/4)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-08-20T04:59:40.2974988Z Build left local git repository checkout dirty 
2021-08-20T04:59:39.7199451Z real	90m53.604s
2021-08-20T04:59:39.7200037Z user	148m7.898s
2021-08-20T04:59:39.7200460Z sys	34m49.490s
2021-08-20T04:59:39.7200849Z + assert_git_not_dirty
2021-08-20T04:59:39.7202168Z + [[ linux-xenial-cuda11.1-py3.6-gcc7-default != *rocm* ]]
2021-08-20T04:59:39.7203866Z + [[ linux-xenial-cuda11.1-py3.6-gcc7-default != *xla* ]]
2021-08-20T04:59:39.7204852Z ++ git status --porcelain
2021-08-20T04:59:40.2972482Z + git_status='?? third_party/breakpad/'
2021-08-20T04:59:40.2973559Z + [[ -n ?? third_party/breakpad/ ]]
2021-08-20T04:59:40.2974316Z + echo 'Build left local git repository checkout dirty'
2021-08-20T04:59:40.2974988Z Build left local git repository checkout dirty
2021-08-20T04:59:40.2975707Z + echo 'git status --porcelain:'
2021-08-20T04:59:40.2976316Z git status --porcelain:
2021-08-20T04:59:40.2976945Z + echo '?? third_party/breakpad/'
2021-08-20T04:59:40.2977451Z ?? third_party/breakpad/
2021-08-20T04:59:40.2977877Z + exit 1
2021-08-20T04:59:40.2978227Z + cleanup
2021-08-20T04:59:40.2978606Z + retcode=1
2021-08-20T04:59:40.2978955Z + set +x
2021-08-20T04:59:40.2979419Z =================== sccache compilation log ===================
2021-08-20T04:59:40.3237285Z =========== If your build fails, please take a look at the log above for possible reasons ===========

See GitHub Actions build linux-bionic-py3.8-gcc9-coverage / test (default, 1, 2, linux.2xlarge) (2/4)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-08-20T00:53:15.3321257Z Build left local git repository checkout dirty 
2021-08-20T00:53:08.0180302Z real	63m52.399s
2021-08-20T00:53:08.0180904Z user	133m8.334s
2021-08-20T00:53:08.0181187Z sys	8m45.364s
2021-08-20T00:53:08.0181490Z + assert_git_not_dirty
2021-08-20T00:53:08.0182845Z + [[ linux-bionic-py3.8-gcc9-coverage-default != *rocm* ]]
2021-08-20T00:53:08.0183971Z + [[ linux-bionic-py3.8-gcc9-coverage-default != *xla* ]]
2021-08-20T00:53:08.0184669Z ++ git status --porcelain
2021-08-20T00:53:15.3318345Z + git_status='?? third_party/breakpad/'
2021-08-20T00:53:15.3319219Z + [[ -n ?? third_party/breakpad/ ]]
2021-08-20T00:53:15.3320098Z + echo 'Build left local git repository checkout dirty'
2021-08-20T00:53:15.3321257Z Build left local git repository checkout dirty
2021-08-20T00:53:15.3322188Z + echo 'git status --porcelain:'
2021-08-20T00:53:15.3323041Z git status --porcelain:
2021-08-20T00:53:15.3323869Z + echo '?? third_party/breakpad/'
2021-08-20T00:53:15.3324533Z ?? third_party/breakpad/
2021-08-20T00:53:15.3325080Z + exit 1
2021-08-20T00:53:15.3325517Z + cleanup
2021-08-20T00:53:15.3325968Z + retcode=1
2021-08-20T00:53:15.3326410Z + set +x
2021-08-20T00:53:15.3327002Z =================== sccache compilation log ===================
2021-08-20T00:53:15.3489580Z =========== If your build fails, please take a look at the log above for possible reasons ===========

See GitHub Actions build linux-bionic-py3.8-gcc9-coverage / test (default, 2, 2, linux.2xlarge) (3/4)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-08-20T01:18:36.4529539Z Build left local git repository checkout dirty 
2021-08-20T01:18:29.1597355Z real	89m31.446s
2021-08-20T01:18:29.1597857Z user	178m21.189s
2021-08-20T01:18:29.1598371Z sys	23m50.473s
2021-08-20T01:18:29.1598695Z + assert_git_not_dirty
2021-08-20T01:18:29.1600426Z + [[ linux-bionic-py3.8-gcc9-coverage-default != *rocm* ]]
2021-08-20T01:18:29.1601422Z + [[ linux-bionic-py3.8-gcc9-coverage-default != *xla* ]]
2021-08-20T01:18:29.1602103Z ++ git status --porcelain
2021-08-20T01:18:36.4526906Z + git_status='?? third_party/breakpad/'
2021-08-20T01:18:36.4527794Z + [[ -n ?? third_party/breakpad/ ]]
2021-08-20T01:18:36.4528695Z + echo 'Build left local git repository checkout dirty'
2021-08-20T01:18:36.4529539Z Build left local git repository checkout dirty
2021-08-20T01:18:36.4530699Z + echo 'git status --porcelain:'
2021-08-20T01:18:36.4531766Z git status --porcelain:
2021-08-20T01:18:36.4532764Z + echo '?? third_party/breakpad/'
2021-08-20T01:18:36.4533618Z ?? third_party/breakpad/
2021-08-20T01:18:36.4534144Z + exit 1
2021-08-20T01:18:36.4534457Z + cleanup
2021-08-20T01:18:36.4534794Z + retcode=1
2021-08-20T01:18:36.4535055Z + set +x
2021-08-20T01:18:36.4535421Z =================== sccache compilation log ===================
2021-08-20T01:18:36.4698542Z =========== If your build fails, please take a look at the log above for possible reasons ===========

See GitHub Actions build linux-xenial-cuda11.1-py3.6-gcc7 / test (default, 2, 2, linux.8xlarge.nvidia.gpu) (4/4)

Step: "Test PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-08-20T05:39:17.6865292Z Build left local git repository checkout dirty 
2021-08-20T05:39:17.1083463Z real	131m15.467s
2021-08-20T05:39:17.1084149Z user	201m51.582s
2021-08-20T05:39:17.1084482Z sys	95m12.818s
2021-08-20T05:39:17.1085487Z + assert_git_not_dirty
2021-08-20T05:39:17.1089109Z + [[ linux-xenial-cuda11.1-py3.6-gcc7-default != *rocm* ]]
2021-08-20T05:39:17.1090487Z + [[ linux-xenial-cuda11.1-py3.6-gcc7-default != *xla* ]]
2021-08-20T05:39:17.1091392Z ++ git status --porcelain
2021-08-20T05:39:17.6862983Z + git_status='?? third_party/breakpad/'
2021-08-20T05:39:17.6863846Z + [[ -n ?? third_party/breakpad/ ]]
2021-08-20T05:39:17.6864614Z + echo 'Build left local git repository checkout dirty'
2021-08-20T05:39:17.6865292Z Build left local git repository checkout dirty
2021-08-20T05:39:17.6866012Z + echo 'git status --porcelain:'
2021-08-20T05:39:17.6867197Z git status --porcelain:
2021-08-20T05:39:17.6868791Z + echo '?? third_party/breakpad/'
2021-08-20T05:39:17.6869456Z ?? third_party/breakpad/
2021-08-20T05:39:17.6869888Z + exit 1
2021-08-20T05:39:17.6870262Z + cleanup
2021-08-20T05:39:17.6870630Z + retcode=1
2021-08-20T05:39:17.6871762Z + set +x
2021-08-20T05:39:17.6872228Z =================== sccache compilation log ===================
2021-08-20T05:39:17.7128322Z =========== If your build fails, please take a look at the log above for possible reasons ===========

1 failure not recognized by patterns:

Job Step Action
GitHub Actions Lint / clang-tidy Checkout PyTorch 🔁 rerun

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@peterbell10
Update on "Kill THCUNN"
8056158 
[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Aug 17, 2021
@peterbell10
Kill THCUNN
570c870 
ghstack-source-id: fbcac13
Pull Request resolved: #63429
@peterbell10
Update on "Kill THCUNN"
9f5aa5a 
[ghstack-poisoned]
@peterbell10
Update on "Kill THCUNN"
97c2c99 
[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Aug 18, 2021
@peterbell10
Kill THCUNN
d1fc08b 
ghstack-source-id: 2092960
Pull Request resolved: #63429
@peterbell10 peterbell10 requested a review from ngimel August 18, 2021 15:25
This was referenced Aug 18, 2021
Closed
Closed
@peterbell10
Update on "Kill THCUNN"
489f709 
[ghstack-poisoned]
@peterbell10 peterbell10 added the module: porting Issues related to porting TH/THNN legacy to ATen native label Aug 19, 2021
@peterbell10
Update on "Kill THCUNN"
cfa52b3 
[ghstack-poisoned]
@peterbell10
Update on "Kill THCUNN"
bb05063 
[ghstack-poisoned]
@ngimel
Copy link
Collaborator

ngimel commented Aug 20, 2021

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 560cd88.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/116/head branch August 27, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: porting Issues related to porting TH/THNN legacy to ATen native open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterbell10 @facebook-github-bot @ngimel @pytorchbot