KEMBAR78
MaybeOwned page for dev wiki by bhosmer · Pull Request #63450 · pytorch/pytorch · GitHub
Skip to content

MaybeOwned page for dev wiki #63450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

MaybeOwned page for dev wiki #63450

wants to merge 2 commits into from
+59 −0

Conversation

@bhosmer
Copy link

@bhosmer bhosmer commented Aug 18, 2021 •
edited
Loading

Stack from ghstack:

Brief guide to understanding MaybeOwned<Tensor>, aimed at C++ PT devs who are obliged to interact with existing uses of it, rather than encouraging new usage.

For reviewers: I haven't yet added a link to this page from anywhere. I'm thinking the right place is the dev wiki main page C++ section but happy to put it wherever makes sense, suggestions welcome.

Differential Revision: D30402313

MaybeOwned page for dev wiki
0c600fd 
[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 18, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e044931 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-scanned failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build linux-xenial-py3.6-gcc5.4 / build (1/1)

Step: "Build PyTorch" (full log | diagnosis details | 🔁 rerun)

2021-08-18T01:56:38.2032153Z Build left local git repository checkout dirty 
2021-08-18T01:56:37.7508803Z multiple input files                 15
2021-08-18T01:56:37.7509036Z 
2021-08-18T01:56:37.7510411Z Cache location                  S3, bucket: Bucket(name=ossci-compiler-cache-circleci-v2, base_url=http://ossci-compiler-cache-circleci-v2.s3.amazonaws.com/)
2021-08-18T01:56:37.7511779Z + assert_git_not_dirty
2021-08-18T01:56:37.7512324Z + [[ linux-xenial-py3.6-gcc5.4 != *rocm* ]]
2021-08-18T01:56:37.7512952Z + [[ linux-xenial-py3.6-gcc5.4 != *xla* ]]
2021-08-18T01:56:37.7513460Z ++ git status --porcelain
2021-08-18T01:56:38.2030461Z + git_status='?? third_party/pocketfft/'
2021-08-18T01:56:38.2031096Z + [[ -n ?? third_party/pocketfft/ ]]
2021-08-18T01:56:38.2031643Z + echo 'Build left local git repository checkout dirty'
2021-08-18T01:56:38.2032153Z Build left local git repository checkout dirty
2021-08-18T01:56:38.2032675Z + echo 'git status --porcelain:'
2021-08-18T01:56:38.2033118Z git status --porcelain:
2021-08-18T01:56:38.2033577Z + echo '?? third_party/pocketfft/'
2021-08-18T01:56:38.2033950Z ?? third_party/pocketfft/
2021-08-18T01:56:38.2034266Z + exit 1
2021-08-18T01:56:38.2034534Z + cleanup
2021-08-18T01:56:38.2034828Z + retcode=1
2021-08-18T01:56:38.2035106Z + set +x
2021-08-18T01:56:38.2035437Z =================== sccache compilation log ===================
2021-08-18T01:56:38.2231890Z =========== If your build fails, please take a look at the log above for possible reasons ===========

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@bhosmer bhosmer requested review from ezyang, ngimel and swolchok August 18, 2021 01:44
Update on "MaybeOwned page for dev wiki"
e044931 
Brief guide to understanding `MaybeOwned<Tensor>`, aimed at C++ PT devs who are obliged to interact with existing uses of it, rather than encouraging new usage. 

For reviewers: I haven't yet added a link to this page from anywhere. I'm thinking the right place is the [dev wiki main page C++ section](https://github.com/pytorch/pytorch/wiki#c) but happy to put it wherever makes sense, suggestions welcome. 

[ghstack-poisoned]
bhosmer pushed a commit that referenced this pull request Aug 18, 2021
MaybeOwned page for dev wiki
8e3f059 
ghstack-source-id: e3e8cdd
Pull Request resolved: #63450
@bhosmer
Copy link
Author

bhosmer commented Aug 18, 2021

@bhosmer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@bhosmer merged this pull request in 11fbd39.

@facebook-github-bot facebook-github-bot deleted the gh/bhosmer/62/head branch August 22, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@ngimel ngimel Awaiting requested review from ngimel

@swolchok swolchok Awaiting requested review from swolchok

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhosmer @facebook-github-bot @ezyang