OpInfo: nn.functional.conv2d #63517
Closed
OpInfo: nn.functional.conv2d #63517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 78287a1 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
mruberry
added
the
triaged
|
Gentle Ping @zou3519 |
This was referenced Aug 24, 2021
Closed
|
Gentle ping @zou3519 :) |
|
Thanks for the ping and sorry for the delay! Will review later today |
zou3519
reviewed
Aug 31, 2021
There was a problem hiding this comment.
This looks great! I added some suggestions for more test cases. Because conv2d is one of PyTorch's most important ops (and also very complicated in terms of what it can call in the backend), we should try to add more test cases especially following existing test cases in common_nn.py
Codecov Report
@@ Coverage Diff @@
## master #63517 +/- ##
==========================================
+ Coverage 66.39% 66.48% +0.08%
==========================================
Files 725 725
Lines 93461 93473 +12
==========================================
+ Hits 62055 62141 +86
+ Misses 31406 31332 -74 |
ngimel
reviewed
Sep 15, 2021
kshitij12345
commented
Sep 15, 2021
zou3519
reviewed
Sep 16, 2021
zou3519
reviewed
Sep 16, 2021
zou3519
reviewed
Sep 16, 2021
zou3519
approved these changes
Sep 16, 2021
zou3519
reviewed
Sep 16, 2021
|
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Sorry, this appears to have broken trunk so I am reverting. |
|
You can view the related failures here: https://hud.pytorch.org/commit/873255c6d95342d144e9d1b633c16410844b934e |
|
This pull request has been reverted by ecfc784. |
|
@kshitij12345 could you send a new PR for this please? The error message implies that the backward is non-deterministic, but I'm not sure if that is true (need to think about it for a little bit...) |
|
Yes, convolution is deterministic so we want to add a |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
Summary: Reland : #63517 Reference: #54261 Reference: pytorch/functorch#78 Pull Request resolved: #65233 Reviewed By: malfet Differential Revision: D31025538 Pulled By: zou3519 fbshipit-source-id: b1cd38c22f4cb8eedd3f958e02dd7410dcbb8d8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #54261
Reference: pytorch/functorch#78
Mostly inspired from #62882