KEMBAR78
[DDP] Remove self.modules_params by rohan-varma · Pull Request #64473 · pytorch/pytorch · GitHub
Skip to content

[DDP] Remove self.modules_params #64473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[DDP] Remove self.modules_params #64473

wants to merge 3 commits into from

Conversation

@rohan-varma
Copy link
Contributor

@rohan-varma rohan-varma commented Sep 3, 2021 •
edited
Loading

@rohan-varma
[DDP] Remove self.modules_params
0b96da9 
Unused after SPMD deprecated.

Differential Revision: [D30745961](https://our.internmc.facebook.com/intern/diff/D30745961/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 3, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 08376e5 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build win-vs2019-cpu-py3 / test (default, 1, 2, windows.4xlarge) (1/1)

Step: "Run test scripts" (full log | diagnosis details | 🔁 rerun)

2021-09-08T00:39:20.6230750Z ERROR [0.000s]: test_poisson_sample (__main__.TestDistributions) 
2021-09-08T00:39:20.6222288Z   File "distributions/test_distributions.py", line 812, in _check_sampler_discrete
2021-09-08T00:39:20.6223269Z     chisq, p = scipy.stats.chisquare(counts[msk], pmf[msk] * num_samples)
2021-09-08T00:39:20.6224322Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6852, in chisquare
2021-09-08T00:39:20.6225274Z     return power_divergence(f_obs, f_exp=f_exp, ddof=ddof, axis=axis,
2021-09-08T00:39:20.6226309Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6694, in power_divergence
2021-09-08T00:39:20.6227163Z     raise ValueError(msg)
2021-09-08T00:39:20.6228342Z ValueError: For each axis slice, the sum of the observed frequencies must agree with the sum of the expected frequencies to a relative tolerance of 1e-08, but the percent differences are:
2021-09-08T00:39:20.6229486Z 0.008265582255680495
2021-09-08T00:39:20.6229737Z 
2021-09-08T00:39:20.6230123Z ======================================================================
2021-09-08T00:39:20.6230750Z ERROR [0.000s]: test_poisson_sample (__main__.TestDistributions)
2021-09-08T00:39:20.6231518Z ----------------------------------------------------------------------
2021-09-08T00:39:20.6232135Z Traceback (most recent call last):
2021-09-08T00:39:20.6233044Z   File "distributions/test_distributions.py", line 1352, in test_poisson_sample
2021-09-08T00:39:20.6233928Z     self._check_sampler_discrete(Poisson(rate),
2021-09-08T00:39:20.6234924Z   File "distributions/test_distributions.py", line 812, in _check_sampler_discrete
2021-09-08T00:39:20.6286878Z     chisq, p = scipy.stats.chisquare(counts[msk], pmf[msk] * num_samples)
2021-09-08T00:39:20.6287984Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6852, in chisquare
2021-09-08T00:39:20.6288928Z     return power_divergence(f_obs, f_exp=f_exp, ddof=ddof, axis=axis,
2021-09-08T00:39:20.6290060Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6694, in power_divergence
2021-09-08T00:39:20.6290894Z     raise ValueError(msg)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Sep 3, 2021
Closed
Closed
@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Sep 3, 2021
@rohan-varma
Update on "[DDP] Remove self.modules_params"
1fb99bf 
Unused after SPMD deprecated.

Differential Revision: [D30745961](https://our.internmc.facebook.com/intern/diff/D30745961/)

cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse agolynski @SciPioneer @H-Huang mrzzd cbalioglu gcramer23

[ghstack-poisoned]
This was referenced Sep 5, 2021
Closed
Closed
Closed
@rohan-varma
Update on "[DDP] Remove self.modules_params"
08376e5 
Unused after SPMD deprecated.

Differential Revision: [D30745961](https://our.internmc.facebook.com/intern/diff/D30745961/)

cc pietern mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse agolynski @SciPioneer @H-Huang mrzzd cbalioglu gcramer23

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 8c09510.

@facebook-github-bot
Copy link
Contributor

This pull request has been reverted by 5bc53ac.

@facebook-github-bot facebook-github-bot deleted the gh/rohan-varma/402/head branch September 12, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaojuanmao zhaojuanmao zhaojuanmao approved these changes

@cbalioglu cbalioglu Awaiting requested review from cbalioglu

@H-Huang H-Huang Awaiting requested review from H-Huang

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@wayi1 wayi1 Awaiting requested review from wayi1

Assignees

No one assigned

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohan-varma @facebook-github-bot @zhaojuanmao