KEMBAR78
fixing trapezoid() comments for clarity by NivekT · Pull Request #64592 · pytorch/pytorch · GitHub
Skip to content

fixing trapezoid() comments for clarity #64592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fixing trapezoid() comments for clarity #64592

wants to merge 2 commits into from

Conversation

@NivekT
Copy link
Contributor

@NivekT NivekT commented Sep 7, 2021 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 7, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit aff727c (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build win-vs2019-cpu-py3 / test (default, 1, 2, windows.4xlarge) (1/1)

Step: "Run test scripts" (full log | diagnosis details | 🔁 rerun)

2021-09-07T20:24:05.8993421Z ERROR [0.000s]: test_poisson_sample (__main__.TestDistributions) 
2021-09-07T20:24:05.8985018Z   File "distributions/test_distributions.py", line 812, in _check_sampler_discrete
2021-09-07T20:24:05.8986009Z     chisq, p = scipy.stats.chisquare(counts[msk], pmf[msk] * num_samples)
2021-09-07T20:24:05.8987077Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6852, in chisquare
2021-09-07T20:24:05.8988039Z     return power_divergence(f_obs, f_exp=f_exp, ddof=ddof, axis=axis,
2021-09-07T20:24:05.8989067Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6694, in power_divergence
2021-09-07T20:24:05.8989926Z     raise ValueError(msg)
2021-09-07T20:24:05.8991106Z ValueError: For each axis slice, the sum of the observed frequencies must agree with the sum of the expected frequencies to a relative tolerance of 1e-08, but the percent differences are:
2021-09-07T20:24:05.8992156Z 0.008265582255680495
2021-09-07T20:24:05.8992410Z 
2021-09-07T20:24:05.8992792Z ======================================================================
2021-09-07T20:24:05.8993421Z ERROR [0.000s]: test_poisson_sample (__main__.TestDistributions)
2021-09-07T20:24:05.8994196Z ----------------------------------------------------------------------
2021-09-07T20:24:05.8994823Z Traceback (most recent call last):
2021-09-07T20:24:05.8995673Z   File "distributions/test_distributions.py", line 1352, in test_poisson_sample
2021-09-07T20:24:05.8996542Z     self._check_sampler_discrete(Poisson(rate),
2021-09-07T20:24:05.8997447Z   File "distributions/test_distributions.py", line 812, in _check_sampler_discrete
2021-09-07T20:24:05.8998480Z     chisq, p = scipy.stats.chisquare(counts[msk], pmf[msk] * num_samples)
2021-09-07T20:24:05.8999607Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6852, in chisquare
2021-09-07T20:24:05.9000563Z     return power_divergence(f_obs, f_exp=f_exp, ddof=ddof, axis=axis,
2021-09-07T20:24:05.9001598Z   File "c:\jenkins\miniconda3\lib\site-packages\scipy\stats\stats.py", line 6694, in power_divergence
2021-09-07T20:24:05.9002450Z     raise ValueError(msg)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@NivekT NivekT requested a review from mruberry September 7, 2021 19:00
@NivekT NivekT added the module: numpy Related to numpy support, and also numpy compatibility of our operators label Sep 7, 2021
@NivekT
Update on "fixing trapezoid() comments for clarity"
aff727c 
cc mruberry rgommers heitorschueroff

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Sep 7, 2021
@NivekT
fixing trapezoid() comments for clarity
8ebc929 
ghstack-source-id: 4b45a0f
Pull Request resolved: #64592
@NivekT
Copy link
Contributor Author

NivekT commented Sep 7, 2021

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mruberry
mruberry approved these changes Sep 7, 2021
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat; thanks @NivekT

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in 1409492.

@facebook-github-bot facebook-github-bot deleted the gh/nivekt/9/head branch September 12, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: numpy Related to numpy support, and also numpy compatibility of our operators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NivekT @facebook-github-bot @mruberry