KEMBAR78
Migrate uses of THCReduceApplyUtils to cuda_utils::BlockReduce by peterbell10 · Pull Request #64713 · pytorch/pytorch · GitHub
Skip to content

Migrate uses of THCReduceApplyUtils to cuda_utils::BlockReduce #64713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Migrate uses of THCReduceApplyUtils to cuda_utils::BlockReduce #64713

wants to merge 1 commit into from

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Sep 8, 2021 •
edited by ngimel
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 8, 2021 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit ae6c990 (more details on the Dr. CI page):

  • 14/14 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build win-vs2019-cuda11.3-py3 / test (default, 2, 2, windows.8xlarge.nvidia.gpu) (1/1)

Step: "Install Cuda" (full log | diagnosis details | 🔁 rerun)

2021-09-09T03:14:01.3404409Z ls: cannot access ...UDA/v11.3/bin/nvcc.exe': No such file or directory 
2021-09-09T03:13:57.7469952Z 
2021-09-09T03:13:57.7470278Z Folders: 11
2021-09-09T03:13:57.7470608Z Files: 130
2021-09-09T03:13:57.7470942Z Size:       907512
2021-09-09T03:13:57.7471299Z Compressed: 111420
2021-09-09T03:13:57.7540828Z + mkdir -p 'C:/Program Files/NVIDIA Corporation/NvToolsExt'
2021-09-09T03:13:58.1784270Z + cp -r NvToolsExt/bin NvToolsExt/docs NvToolsExt/include NvToolsExt/lib NvToolsExt/samples 'C:/Program Files/NVIDIA Corporation/NvToolsExt/'
2021-09-09T03:14:01.3201849Z + export 'NVTOOLSEXT_PATH=C:\Program Files\NVIDIA Corporation\NvToolsExt\'
2021-09-09T03:14:01.3203135Z + NVTOOLSEXT_PATH='C:\Program Files\NVIDIA Corporation\NvToolsExt\'
2021-09-09T03:14:01.3204124Z + ls '/c/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.3/bin/nvcc.exe'
2021-09-09T03:14:01.3404409Z ls: cannot access '/c/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.3/bin/nvcc.exe': No such file or directory
2021-09-09T03:14:01.3408542Z + echo 'CUDA installation failed'
2021-09-09T03:14:01.3409609Z + mkdir -p /c/w/build-results
2021-09-09T03:14:01.3410412Z CUDA installation failed
2021-09-09T03:14:01.3606406Z + 7z a 'c:\w\build-results\cuda_install_logs.7z' cuda_install_logs
2021-09-09T03:14:01.4562261Z 
2021-09-09T03:14:01.4563877Z 7-Zip 19.00 (x64) : Copyright (c) 1999-2018 Igor Pavlov : 2019-02-21
2021-09-09T03:14:01.4564689Z 
2021-09-09T03:14:01.4565419Z Scanning the drive:
2021-09-09T03:14:01.4566247Z 1 folder, 0 files, 0 bytes
2021-09-09T03:14:01.4566790Z

13 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_linux_xenial_py3_clang5_mobile_custom_build_dynamic Build 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang5_mobile_build Build 🔁 rerun
CircleCI pytorch_macos_10_13_py3_build Build 🔁 rerun
CircleCI pytorch_ios_12_0_0_x86_64_full_jit_build Build 🔁 rerun
CircleCI pytorch_vulkan_linux_bionic_py3_6_clang9_build Build 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang7_asan_build Build 🔁 rerun
CircleCI pytorch_xla_linux_bionic_py3_6_clang9_build Build 🔁 rerun
CircleCI pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit pytorch android gradle custom build single architecture (for PR) 🔁 rerun
CircleCI pytorch_macos_10_15_py3_build Build 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang7_onnx_build Build 🔁 rerun
CircleCI pytorch_ios_12_0_0_x86_64_build Build 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang5_mobile_custom_build_static Build 🔁 rerun
CircleCI pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single pytorch android gradle custom build single architecture (for PR) 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

peterbell10 added a commit that referenced this pull request Sep 8, 2021
@peterbell10
Migrate uses of THCReduceApplyUtils to cuda_utils::BlockReduce
8ac50d5 
ghstack-source-id: eb7896f
Pull Request resolved: #64713
@peterbell10 peterbell10 requested a review from ngimel September 8, 2021 23:01
@peterbell10 peterbell10 added the module: porting Issues related to porting TH/THNN legacy to ATen native label Sep 8, 2021
@ngimel
Copy link
Collaborator

ngimel commented Sep 8, 2021

@pytorchbot ciflow rerun

@ngimel
Copy link
Collaborator

ngimel commented Sep 9, 2021

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Collaborator

ngimel commented Sep 9, 2021 •
edited
Loading

Unfortunately, I cannot trigger win cuda 11.3 build on this PR, but let's hope the change fixes the error.
Edit: @peterbell10 you can try adding yourself to #64124, and then add ciflow labels/comments to trigger the necessary build, see ciflow wiki

@malfet malfet assigned pytorchbot and unassigned pytorchbot Sep 9, 2021
@malfet
Copy link
Contributor

malfet commented Sep 9, 2021

Added Peter to ciflow opt-in and scheduled 11.3 builds

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in d0b207e.

@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/137/head branch September 12, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: porting Issues related to porting TH/THNN legacy to ATen native open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterbell10 @facebook-github-bot @ngimel @malfet @pytorchbot