Disable torch.complex32 dtype #70606

anjali411 · 2022-01-04T16:52:10Z

Related #69209 (comment)

Stack from ghstack:

-> Disable torch.complex32 dtype #70606

cc @ezyang @gchanan @anjali411 @dylanbespalko @mruberry @lezcano @nikitaved

Differential Revision: D33954861

[ghstack-poisoned]

pytorch-probot · 2022-01-04T16:52:13Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/b7b1a6891a12ca666d78920f992f381b55fab725/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default,ciflow/all

Workflows	Labels (bold enabled)	Status
Triggered Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
docker-builds	`ciflow/all`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	✅ triggered
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	✅ triggered
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	✅ triggered
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	✅ triggered
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

facebook-github-bot · 2022-01-04T16:52:17Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/70606
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit cd0cc98 (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

linux-bionic-py3.7-clang9 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-02-09T18:44:49.9527930Z AttributeError: module 'torch' has no attribute 'complex32'

2022-02-09T18:44:49.9525346Z   File "/opt/conda/lib/python3.7/runpy.py", line 263, in run_path
2022-02-09T18:44:49.9525585Z     pkg_name=pkg_name, script_name=fname)
2022-02-09T18:44:49.9525822Z   File "/opt/conda/lib/python3.7/runpy.py", line 96, in _run_module_code
2022-02-09T18:44:49.9526077Z     mod_name, mod_spec, pkg_name, script_name)
2022-02-09T18:44:49.9526305Z   File "/opt/conda/lib/python3.7/runpy.py", line 85, in _run_code
2022-02-09T18:44:49.9526523Z     exec(code, run_globals)
2022-02-09T18:44:49.9526770Z   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 465, in <module>
2022-02-09T18:44:49.9527031Z     class XLATestBase(DeviceTypeTestBase):
2022-02-09T18:44:49.9527312Z   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 468, in XLATestBase
2022-02-09T18:44:49.9527602Z     torch.half, torch.complex32, torch.complex64, torch.complex128
2022-02-09T18:44:49.9527930Z AttributeError: module 'torch' has no attribute 'complex32'
2022-02-09T18:44:50.1390149Z + cleanup
2022-02-09T18:44:50.1390653Z + retcode=1
2022-02-09T18:44:50.1390854Z + set +x
2022-02-09T18:44:50.1436421Z ##[error]Process completed with exit code 1.
2022-02-09T18:44:50.1513614Z ##[group]Run # Ensure the working directory gets chowned back to the current user
2022-02-09T18:44:50.1513960Z �[36;1m# Ensure the working directory gets chowned back to the current user�[0m
2022-02-09T18:44:50.1514324Z �[36;1mdocker run --rm -v "$(pwd)":/v -w /v "${ALPINE_IMAGE}" chown -R "$(id -u):$(id -g)" .�[0m
2022-02-09T18:44:50.1967645Z shell: /usr/bin/bash -e {0}
2022-02-09T18:44:50.1967847Z env:
2022-02-09T18:44:50.1968062Z   BUILD_ENVIRONMENT: linux-bionic-py3.7-clang9

1 failure not recognized by patterns:

Job	Step	Action
^{ios-12-5-1-arm64-metal / build}	^Unknown	🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

anjali411 · 2022-01-04T17:17:16Z

@ngimel should we just cherry-pick this for the next release?

[ghstack-poisoned]

ghstack-source-id: 3c9cb13 Pull Request resolved: #70606

mruberry · 2022-01-04T17:45:46Z

torch/testing/_comparison.py

    | :attr:`~torch.bfloat16`   | ``1.6e-2`` | ``1e-5`` |
    +---------------------------+------------+----------+
    | :attr:`~torch.float32`    | ``1.3e-6`` | ``1e-5`` |
    +---------------------------+------------+----------+


mruberry

Cool! (So long as the tests pass.)

Note from offline meeting: @ngimel plans to file a follow-up issue for proper ComplexHalf support

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved [ghstack-poisoned]

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved [ghstack-poisoned]

anjali411 · 2022-01-10T17:54:24Z

@pytorchbot ciflow rerun -l ciflow/all

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved [ghstack-poisoned]

anjali411 · 2022-02-02T21:55:08Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

ghstack-source-id: dc959ef Pull Request resolved: #70606

anjali411 · 2022-02-02T22:14:34Z

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

ghstack-source-id: 483e153 Pull Request resolved: #70606

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

anjali411 · 2022-02-03T21:33:08Z

@JackCaoG I will be cherry-picking this PR in the 1.11 release branch and looks like it'll require an xla side change (remove torch.complex32 from this list https://github.com/pytorch/xla/blob/3bb039c8e8cff30e23394e47bf67443b0c200100/test/pytorch_test_base.py#L467-L469)

JackCaoG · 2022-02-03T21:56:08Z

@anjali411 Seems like we only need to remove this dtype from our repo, I can do that and backport to our 1.11 branch.

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

ghstack-source-id: da6772b Pull Request resolved: #70606

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

ghstack-source-id: 8f4ae84 Pull Request resolved: #70606

@lezcano

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

ghstack-source-id: 856df6d Pull Request resolved: #70606

malfet · 2022-02-15T01:31:29Z

@anjali411 correct me if I'm wrong, but 13b403b has been landed in 1.11, so we probably can remove the milestone (and close this PR) after xla change is landed

JackCaoG · 2022-02-15T01:36:24Z

@malfet I just merge the pt/xla 1.11 pr. Pytroch/xla 1.11 branch is missing several important prs. I am thinking about recut the 1.11 from master which is a bit easier than me manually porting a bunch of pr at the same time. Will let you know if I do that.

anjali411 · 2022-02-15T14:50:17Z

@anjali411 correct me if I'm wrong, but 13b403b has been landed in 1.11, so we probably can remove the milestone (and close this PR) after xla change is landed

yup absolutely!

Disable torch.complex32 dtype

a8352cd

[ghstack-poisoned]

anjali411 requested review from BowenBao, IvanYashchuk, lezcano, nikitaved and shubhambhokare1 as code owners January 4, 2022 16:52

pytorch-probot bot added the ciflow/default label Jan 4, 2022

facebook-github-bot added the cla signed label Jan 4, 2022

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jan 4, 2022

anjali411 requested review from albanD and ngimel January 4, 2022 17:01

Update on "Disable torch.complex32 dtype"

2a5014e

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 4, 2022

Disable torch.complex32 dtype

5d4d9b8

ghstack-source-id: 3c9cb13 Pull Request resolved: #70606

anjali411 added module: complex Related to complex number support in PyTorch module: bc-breaking Related to a BC-breaking change and removed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 4, 2022

mruberry reviewed Jan 4, 2022

View reviewed changes

mruberry self-requested a review January 4, 2022 17:46

mruberry approved these changes Jan 4, 2022

View reviewed changes

lezcano removed their request for review January 5, 2022 08:29

IvanYashchuk removed their request for review January 5, 2022 16:46

Update on "Disable torch.complex32 dtype"

751fd87

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved [ghstack-poisoned]

Update on "Disable torch.complex32 dtype"

4410a0c

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved [ghstack-poisoned]

ngimel mentioned this pull request Jan 23, 2022

ComplexHalf support #71680

Closed

Update on "Disable torch.complex32 dtype"

b34592a

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved [ghstack-poisoned]

anjali411 added this to the 1.11.0 milestone Feb 2, 2022

Update on "Disable torch.complex32 dtype"

9a4b215

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Feb 2, 2022

Disable torch.complex32 dtype

b5584bc

ghstack-source-id: dc959ef Pull Request resolved: #70606

Update on "Disable torch.complex32 dtype"

e7141ab

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Feb 3, 2022

Disable torch.complex32 dtype

cf2c01e

ghstack-source-id: 483e153 Pull Request resolved: #70606

Update on "Disable torch.complex32 dtype"

7469427

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

Update on "Disable torch.complex32 dtype"

94ce6fb

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Feb 3, 2022

Disable torch.complex32 dtype

2343e0b

ghstack-source-id: da6772b Pull Request resolved: #70606

JackCaoG mentioned this pull request Feb 4, 2022

Remove complex32 pytorch/xla#3340

Closed

anjali411 mentioned this pull request Feb 7, 2022

Disable torch.complex32 in Pytorch 1.11 release #72437

Closed

Update on "Disable torch.complex32 dtype"

86ac772

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Feb 7, 2022

Disable torch.complex32 dtype

6162a39

ghstack-source-id: 8f4ae84 Pull Request resolved: #70606

Update on "Disable torch.complex32 dtype"

cd0cc98

Related #69209 (comment) cc ezyang gchanan anjali411 dylanbespalko mruberry @lezcano nikitaved Differential Revision: [D33954861](https://our.internmc.facebook.com/intern/diff/D33954861) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Feb 9, 2022

Disable torch.complex32 dtype

13b403b

ghstack-source-id: 856df6d Pull Request resolved: #70606

anjali411 removed this from the 1.11.0 milestone Feb 15, 2022

facebook-github-bot deleted the branch gh/anjali411/138/base March 12, 2022 15:16

facebook-github-bot closed this Mar 12, 2022

facebook-github-bot deleted the gh/anjali411/138/head branch March 12, 2022 15:16

Disable torch.complex32 dtype #70606

Disable torch.complex32 dtype #70606

Uh oh!

Conversation

anjali411 commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-probot bot commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

facebook-github-bot commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

linux-bionic-py3.7-clang9 / test (xla, 1, 1, linux.2xlarge) (1/1)

1 failure not recognized by patterns:

Uh oh!

anjali411 commented Jan 4, 2022

Uh oh!

mruberry Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

anjali411 commented Jan 10, 2022

Uh oh!

anjali411 commented Feb 2, 2022

Uh oh!

anjali411 commented Feb 2, 2022

Uh oh!

anjali411 commented Feb 3, 2022

Uh oh!

JackCaoG commented Feb 3, 2022

Uh oh!

malfet commented Feb 15, 2022

Uh oh!

JackCaoG commented Feb 15, 2022

Uh oh!

anjali411 commented Feb 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anjali411 commented Jan 4, 2022 •

edited

Loading

pytorch-probot bot commented Jan 4, 2022 •

edited

Loading

facebook-github-bot commented Jan 4, 2022 •

edited

Loading