KEMBAR78
fix complex abs/angle output format by ngimel · Pull Request #77585 · pytorch/pytorch · GitHub
Skip to content

fix complex abs/angle output format #77585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: Add extra debug info for the super common "index out of bounds" error.
wants to merge 1 commit into from
Closed

fix complex abs/angle output format #77585

wants to merge 1 commit into from

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented May 16, 2022 •
edited by mruberry
Loading

Fixes #77526

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 16, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit 5151e8d (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.1-py3.7 / test (default, 1, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-17T18:36:27.4415080Z FAIL [0.126s]: test_Conv2d_groups_nobias_v2 (__main__.TestNN) 
2022-05-17T18:36:27.3416826Z   test_xavier_normal_errors_on_inputs_smaller_than_2d (__main__.TestNNInit) ... ok (0.001s)
2022-05-17T18:36:27.4259463Z   test_xavier_uniform (__main__.TestNNInit) ... ok (0.084s)
2022-05-17T18:36:27.4266944Z   test_xavier_uniform_errors_on_inputs_smaller_than_2d (__main__.TestNNInit) ... ok (0.001s)
2022-05-17T18:36:27.4302283Z   test_load_state_dict_module_pre_hook (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-17T18:36:27.4336863Z   test_load_state_dict_post_hook (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-17T18:36:27.4372068Z   test_load_state_dict_post_hook_backward_compatibility (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-17T18:36:27.4401597Z   test_load_state_dict_pre_hook (__main__.TestStateDictHooks) ... ok (0.003s)
2022-05-17T18:36:27.4407992Z   test_no_extra_ref_to_module (__main__.TestStateDictHooks) ... ok (0.001s)
2022-05-17T18:36:27.4409329Z 
2022-05-17T18:36:27.4409715Z ======================================================================
2022-05-17T18:36:27.4415080Z FAIL [0.126s]: test_Conv2d_groups_nobias_v2 (__main__.TestNN)
2022-05-17T18:36:27.4416889Z ----------------------------------------------------------------------
2022-05-17T18:36:27.4417837Z Traceback (most recent call last):
2022-05-17T18:36:27.4418721Z   File "test_nn.py", line 6876, in test_Conv2d_groups_nobias_v2
2022-05-17T18:36:27.4419693Z     self.assertEqual(output, torch.cat([output1, output2], 1))
2022-05-17T18:36:27.4421817Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 2258, in assertEqual
2022-05-17T18:36:27.4423253Z     msg=msg,
2022-05-17T18:36:27.4425089Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1086, in assert_equal
2022-05-17T18:36:27.4426185Z     raise error_metas[0].to_error()
2022-05-17T18:36:27.4427971Z AssertionError: Tensor-likes are not close!
2022-05-17T18:36:27.4428553Z
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@ngimel ngimel requested a review from mruberry May 16, 2022 19:31
@ngimel ngimel mentioned this pull request May 16, 2022
Closed
@ngimel
Copy link
Collaborator Author

ngimel commented May 17, 2022

@pytorchbot rebase this

@pytorchmergebot
Copy link
Collaborator

Successfully rebased ngimel/abs_complex onto master, please pull locally before adding more changes (for example, via git checkout ngimel/abs_complex && git pull --rebase)

mruberry
mruberry approved these changes May 17, 2022
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ngimel
Copy link
Collaborator Author

ngimel commented May 17, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

Hey @ngimel.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

pytorchmergebot pushed a commit that referenced this pull request May 18, 2022
@pytorchmergebot
make to properly support permutation (#77610)
bfb1206 
Fixes #77600 (tests to come from #77585)

Pull Request resolved: #77610
Approved by: https://github.com/ezyang, https://github.com/mruberry
facebook-github-bot pushed a commit that referenced this pull request May 18, 2022
@facebook-github-bot
fix complex abs/angle output format (#77585) (#77585)
67edf43 
Summary:
Fixes #77526

Pull Request resolved: #77585
Approved by: https://github.com/mruberry

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/059c439ed9bd675102a0c6cf1fcf907c88288960

Reviewed By: b0noI

Differential Revision: D36466064

Pulled By: ngimel

fbshipit-source-id: 915414fe6ab65d40b10e83d1aad3d8e759c2a7c3
facebook-github-bot pushed a commit that referenced this pull request May 20, 2022
@facebook-github-bot
make to properly support permutation (#77610) (#77610)
3079a18 
Summary:
Fixes #77600 (tests to come from #77585)

Pull Request resolved: #77610
Approved by: https://github.com/ezyang, https://github.com/mruberry

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bfb1206d09d9c04f4bed5ed117d131f1984ea501

Reviewed By: seemethere, b0noI

Differential Revision: D36493959

Pulled By: ngimel

fbshipit-source-id: cd60178cd827a0ba4a62ad6a52a6d6f0fa1c217e
@mruberry mruberry mentioned this pull request May 21, 2022
Open
@github-actions github-actions bot deleted the ngimel/abs_complex branch February 16, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

cla signed Merged module: primTorch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[primTorch] Strides for complex abs are incorrect

4 participants

@ngimel @facebook-github-bot @pytorchmergebot @mruberry