[c10d] Start deprecating *_multigpu APIs #85961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwen2501
requested review from
H-Huang,
awgu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85961
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 1 PendingAs of commit 217d2c5: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (c10d)
facebook-github-bot
added
cla signed
oncall: distributed
|
The "CUDA out of memory" CI error is unrelated |
XilunWu
approved these changes
Sep 30, 2022
H-Huang
reviewed
Sep 30, 2022
| """ | ||
| warnings.warn( | ||
| "torch.distributed.broadcast_multigpu will be deprecated. If you must " |
There was a problem hiding this comment.
H-Huang
approved these changes
Sep 30, 2022
|
@pytorchbot merge -f 'The CUDA out of memory error is unrelated to this change' |
|
@pytorchbot successfully started a merge job. Check the current status here. |
mehtanirav
pushed a commit
that referenced
this pull request
Oct 4, 2022
### Deprecation reasons: - For most users training is on one GPU per process so these APIs are rarely used - They added one more API dimension - They can be expressed in a composed manner - They are not abstracted – specific to GPU - They caused backend APIs and implementations to have nested `std::vector<std::vector<Tensor>>`, which is hard to read or maintain Pull Request resolved: #85961 Approved by: https://github.com/XilunWu, https://github.com/H-Huang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation reasons:
std::vector<std::vector<Tensor>>, which is hard to read or maintain