Deprecate [Flux|Mono|Synchronous]Sink currentContext #2974
Merged
+146
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
approved these changes
Mar 17, 2022
This commit deprecates currentContext method in FluxSink, MonoSink and SynchronousSink in favor of the newly introduced getContextView. The methods are slated for removal in 3.6.0 at the earliest. These were overlooked in the 3.4.0 release where other Context-returning methods were deprecated. Fixes #2971.
simonbasle
force-pushed
the
2971-depreacteCurrentContextInOldSinks
branch
from
fe9c6bc to
d7c3a51
Compare
|
@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to |
|
NB: This will be released in 3.5.0-M1 in March before it is released in 3.4.17 in April. |
simonbasle
added a commit
that referenced
this pull request
Mar 18, 2022
Released in 3.5.0-M1. Adapted test to account for `take(long, boolean)` changes.
simonbasle
added a commit
that referenced
this pull request
Apr 20, 2022
This commit backports #3021, a default implementation of the `contextView()` method of the FluxSink, MonoSink and SynchronousSink "old sinks" classes. The backport is necessary because the new method was not added only in 3.5.0-M1 as initially stated, but in 3.4.17 as well. Backport of commit 6eecf85. See #2971, #2974 and #3021.
simonbasle
added a commit
that referenced
this pull request
Apr 20, 2022
This commit backports #3021, a default implementation of the `contextView()` method of the FluxSink, MonoSink and SynchronousSink "old sinks" classes. The backport is necessary because the new method was not added only in 3.5.0-M1 as initially stated, but in 3.4.17 as well. Backport of commit 6eecf85. See #2971, #2974 and #3021.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit deprecates currentContext method in FluxSink, MonoSink and
SynchronousSink in favor of the newly introduced getContextView.
The methods are slated for removal in 3.6.0 at the earliest. These were
overlooked in the 3.4.0 release where other Context-returning methods
were deprecated.
Fixes #2971.