KEMBAR78
Avoid FluxReplay buffer retaining/leaking with tiny TTL by simonbasle · Pull Request #2998 · reactor/reactor-core · GitHub
Skip to content

Avoid FluxReplay buffer retaining/leaking with tiny TTL #2998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2022
Merged

Avoid FluxReplay buffer retaining/leaking with tiny TTL #2998

merged 4 commits into from
Apr 7, 2022

Conversation

@simonbasle
Copy link
Contributor

@simonbasle simonbasle force-pushed the 2994-fluxReplayDurationZeroLeak branch from 91910fd to 5686866 Compare April 5, 2022 13:31
@simonbasle
Copy link
Contributor Author

note: in the test class, on top of the additional 4 tests, a few polishing changes have been made:

  • moved the abstract test configuration up at the top again so that "this is the beginning of tests" comment makes sense
  • turned info-level logging into debug level logging to avoid logging spam
  • avoid setting up the VirtualTimeScheduler if no time manipulation is done in the test (via @Tag annotation and TestInfo checking)

@simonbasle simonbasle marked this pull request as ready for review April 7, 2022 10:04
@simonbasle simonbasle requested a review from a team as a code owner April 7, 2022 10:04
@simonbasle simonbasle added this to the 3.4.17 milestone Apr 7, 2022
@simonbasle simonbasle added type/bug A general bug area/performance This belongs to the performance theme labels Apr 7, 2022
@simonbasle simonbasle requested a review from OlegDokuka April 7, 2022 10:04
@simonbasle simonbasle changed the title Avoid FluxReplay retaining buffer with Duration.ZERO Avoid FluxReplay buffer retaining/leaking with tiny TTL Apr 7, 2022
@simonbasle simonbasle merged commit 5297df9 into 3.4.x Apr 7, 2022
@simonbasle simonbasle deleted the 2994-fluxReplayDurationZeroLeak branch April 7, 2022 14:56
@reactorbot
Copy link

@simonbasle this PR seems to have been merged on a maintenance branch, please ensure the change is merge-forwarded to intermediate maintenance branches and up to main 🙇

simonbasle added a commit that referenced this pull request Apr 7, 2022
@simonbasle
Merge #2998 into 3.5.0-M2
ff76d76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@OlegDokuka OlegDokuka OlegDokuka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/performance This belongs to the performance theme type/bug A general bug

Projects

None yet

Milestone

3.4.17

Development

Successfully merging this pull request may close these issues.

3 participants

@simonbasle @reactorbot @OlegDokuka